Skip to content

Graduate PodLifecycleSleepAction to GA #132595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Graduate PodLifecycleSleepAction to GA #132595

wants to merge 1 commit into from
+7 −8

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Jun 28, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduate PodLifecycleSleepAction to GA

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

PodLifecycleSleepAction is graduated to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3960

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 28, 2025
@AxeZhan
Copy link
Member Author

AxeZhan commented Jun 28, 2025

/cc @thockin @aojea

@k8s-ci-robot k8s-ci-robot requested review from aojea and thockin June 28, 2025 15:04
@aojea
Copy link
Member

aojea commented Jun 29, 2025

we have the tests running without issues, have you verified?

@AxeZhan
Copy link
Member Author

AxeZhan commented Jun 30, 2025

we have the tests running without issues, have you verified?

The aggregated results shows no error in recent 15 days:
https://storage.googleapis.com/k8s-triage/index.html?text=unexpected%20delay%20duration%20before%20killing%20the%20pod

@pacoxu
Copy link
Member

pacoxu commented Jul 1, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4d665364032cff9c261847cf07c6464575dfa395

@aojea
Copy link
Member

aojea commented Jul 1, 2025

I do not see those tests running on the testgrid , I'm looking for "Lifecycle Sleep Hook"

@aojea
Copy link
Member

aojea commented Jul 1, 2025

ok, they are running in blocking adn stable https://testgrid.k8s.io/sig-release-master-blocking#kind-master&include-filter-by-regex=Sleep%20Hook

/lgtm
/approve

Thanks for the great work and the patience

/assign @thockin

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea, AxeZhan
Once this PR has been reviewed and has the lgtm label, please assign msau42, sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@bobbypage bobbypage Awaiting requested review from bobbypage

@aojea aojea Awaiting requested review from aojea

@thockin thockin Awaiting requested review from thockin

Assignees

@pacoxu pacoxu

@thockin thockin

@aojea aojea

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AxeZhan @k8s-ci-robot @aojea @pacoxu @thockin