Skip to content

Update kubectl kustomize to kustomize/v5.7.0 #132593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update kubectl kustomize to kustomize/v5.7.0 #132593

wants to merge 1 commit into from
+909 −707

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented Jun 28, 2025

What type of PR is this?

/kind cleanup
/sig cli
/priority important-soon

What this PR does / why we need it:

This upgrades kustomize-in-kubectl to v5.7.0

Which issue(s) this PR fixes:

This is a go.mod change to upgrade the kustomize
dependency from v5.6.0 to v5.7.0

Special notes for your reviewer:

This PR includes dependencies cleanup of two PR:

Does this PR introduce a user-facing change?

Upgrades functionality of `kubectl kustomize` as described at https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.7.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 28, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Jun 28, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/kubectl labels Jun 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from brianpursley, deads2k and a team June 28, 2025 07:45
@dims
Copy link
Member

dims commented Jun 28, 2025

xref: shlex - #120276
xref: yaml - #132056

@dims
Copy link
Member

dims commented Jun 28, 2025

@koba1t there seems to be an extra file -
staging/src/k8s.io/kubectl/pkg/cmd/version/version.go-e can you please delete it?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2025
@koba1t
Update kubectl kustomize to kustomize/v5.7.0
410f04b 
Update kubectl kustomize to kyaml/v0.20.0, cmd/config/v0.20.0, api/v0.20.0, kustomize/v5.7.0
@koba1t koba1t force-pushed the update/kubectl-in-kustomize_to_v5.7.0 branch from 2b7847e to 410f04b Compare June 28, 2025 12:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2025
@koba1t
Copy link
Member Author

koba1t commented Jun 28, 2025

I was remove that file.

@dims
Copy link
Member

dims commented Jun 28, 2025

/hold cancel

/approve

will give it some time for the sig-cli folks to take a look. thanks @koba1t !!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2025
@koba1t
Copy link
Member Author

koba1t commented Jun 28, 2025

/retest

@dims
Copy link
Member

dims commented Jun 30, 2025

/assign @soltysh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koba1t @k8s-ci-robot @dims @soltysh