Skip to content

[WIP] E2E test PodLevelResources feature gate enable->disable->enable #132588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[WIP] E2E test PodLevelResources feature gate enable->disable->enable #132588

wants to merge 1 commit into from

Conversation

annasong20
Copy link

Test the PodLevelResources feature gate enable, disable, then re-enable on kubelet. Verify that pods with pod-level resources continue to exist when the feature gate is disabled, but new pods are rejected until the feature gate is re-enabled.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Share progress on Scenario 2 of #132446 for future assignees.

Which issue(s) this PR is related to:

Targets Scenario 2 of #132446.

Special notes for your reviewer:

This test code has never been run. Treat only as reference and not as authoritative.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@annasong20
Test toggling PodLevelResources
8886b41 
Test the PodLevelResources feature gate enable, disable, then re-enable
on kubelet. Verify that pods with pod-level resources continue to exist
when the feature gate is disabled, but new pods are rejected until the
feature gate is re-enabled.
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 27, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: annasong20
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annasong20
Copy link
Author

/unassign @andrewsykim

@annasong20
Copy link
Author

/uncc @andrewsykim

@k8s-ci-robot k8s-ci-robot removed the request for review from andrewsykim June 27, 2025 21:32
@annasong20
Copy link
Author

/uncc @kannon92

@k8s-ci-robot k8s-ci-robot removed the request for review from kannon92 June 27, 2025 21:32
@annasong20
Copy link
Author

/cc @ndixita

Just an FYI. As explained in the description, this PR is not in a state that's ready for review. It only serves as extra information for the next assignee.

@k8s-ci-robot k8s-ci-robot requested a review from ndixita June 27, 2025 21:34
@annasong20 annasong20 mentioned this pull request Jun 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndixita ndixita Awaiting requested review from ndixita

Assignees
No one assigned
Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annasong20 @k8s-ci-robot