Skip to content

DRA kubelet: remove v1alpha4 #132574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

DRA kubelet: remove v1alpha4 #132574

merged 2 commits into from
Jun 30, 2025

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jun 27, 2025

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

v1alpha4 was added in 1.31 and superseded by v1beta1 in 1.32. Since that release, plugins are also required to advertise the supported gRPC services during registration. In practice, all known DRA drivers use the helper code from 1.32 or newer and thus don't need the legacy support.

Which issue(s) this PR is related to:

#131903
KEP: kubernetes/enhancements#4381

Special notes for your reviewer:

Includes a minor v1beta1 API clarification as a drive-by-change to minimize the number of PRs which need API approval and to avoid updating v1alpha4 the same way, only to remove it then in another PR.

cc @byako

Does this PR introduce a user-facing change?

DRA: the v1alpha4 kubelet gRPC API (added in 1.31, superseded in 1.32) is no longer supported. DRA drivers using the helper package from Kubernetes  >= 1.32 use the v1beta1 API and continue to be supported.

pohly added 2 commits June 27, 2025 09:30
@pohly
DRA kubelet: API clarification
005cef3 
It's not okay to drop a claim from the response just because it encountered no
error. We want to be sure that a DRA driver really looked at the claim.
@pohly
DRA kubelet: remove v1alpha4
a57f15e 
v1alpha4 was added in 1.31 and superseded by v1beta1 in 1.32. Since that
release, plugins are also required to advertise the supported gRPC services
during registration. In practice, all known DRA drivers use the helper code
from 1.32 or newer and thus don't need the legacy support.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and klueska June 27, 2025 08:14
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jun 27, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 27, 2025
pohly added a commit to pohly/kubernetes that referenced this pull request Jun 27, 2025
@pohly
merge kubernetes#132574 dra-kubelet-v1alpha4-removal
1bc6516
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

byako
byako approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@byako byako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pohly
Copy link
Contributor Author

pohly commented Jun 27, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 27, 2025 •
edited
Loading

@pohly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master a57f15e link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pohly
Copy link
Contributor Author

pohly commented Jun 28, 2025

/skip

@pohly
Copy link
Contributor Author

pohly commented Jun 28, 2025

/assign @bart0sh

For review.

/assign @klueska

For approval.

@bart0sh
Copy link
Contributor

bart0sh commented Jun 29, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 24c568d2bc019d042156ff134fe5b9afecf3dbd7

klueska
klueska approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: byako, klueska, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit e7b9457 into kubernetes:master Jun 30, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska approved these changes

@byako byako byako approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees

@klueska klueska

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🆕 New
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@pohly @k8s-ci-robot @k8s-triage-robot @bart0sh @klueska @byako