WIP: Format memory quantity to human readable string #132571
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @gemmahou. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gemmahou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
| @@ -460,6 +460,71 @@ func (q *Quantity) CanonicalizeBytes(out []byte) (result, suffix []byte) { | |||
| } | |||
| } | |||
|
|
|||
| func ToHumanReadableString(q *Quantity) string { | |||
There was a problem hiding this comment.
Do we have complete unit tests for this func? 🤔
What type of PR is this?
/kind bug
What this PR does / why we need it:
To improve UX, this PR implements a feature (may need to be controlled by a flag) that converts fractional memory quantities into a human-readable format when using
kubectl describe. This change only affects the display output (withkubectl describe) and should not impact the underlying API interactions.For instance, if a requested memory is 0.1Gi, the API should still use its byte value, 107374182400m, during CREATE or GET operations. However, when describing the resource, 107374182400m would be converted and presented as 0.1Gi.
Which issue(s) this PR is related to:
kubernetes/kubectl#1729 and kubernetes/kubectl#1597
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Yes
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: