Skip to content

Add DRA test #132566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add DRA test #132566

wants to merge 1 commit into from
+98 −49

Conversation

barney-s
Copy link
Contributor

Test Scenario:
Create a ResourceSlice that uses the PerDeviceNodeSelection and make sure that the devices ends up on the right nodes

What type of PR is this?

What this PR does / why we need it:

This PR adds a test to the DRA feature that is under active development.

Which issue(s) this PR is related to:

#132136

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/4815-dra-partitionable-devices

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and pohly June 26, 2025 21:34
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 26, 2025
@barney-s
Copy link
Contributor Author

/assign @mortent

@barney-s barney-s force-pushed the 132136_fix branch 2 times, most recently from b5ba7da to 0f07bae Compare June 26, 2025 23:17
mortent
mortent reviewed Jun 27, 2025
View reviewed changes
@barney-s barney-s requested a review from mortent June 28, 2025 15:45
mortent
mortent reviewed Jun 28, 2025
View reviewed changes
mortent
mortent reviewed Jun 28, 2025
View reviewed changes
@barney-s barney-s requested a review from mortent June 28, 2025 23:59
@barney-s barney-s force-pushed the 132136_fix branch 2 times, most recently from d73c774 to 0ccdc71 Compare June 29, 2025 01:04
@barney-s
Add a test: Create a ResourceSlice that uses the PerDeviceNodeSelecti…
0b1011f 
…on and make sure that the devices ends up on the right nodes
mortent
mortent approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member

@mortent mortent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b01f390c676170c0120d227da40c4f66cc2b3551

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barney-s, mortent
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mortent
Copy link
Member

mortent commented Jun 30, 2025

/assign @pohly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortent mortent mortent approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@pohly pohly Awaiting requested review from pohly

Assignees

@mortent mortent

@pohly pohly

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🆕 New
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barney-s @k8s-ci-robot @mortent @pohly