Skip to content

kubelet: remove legacy log symlinks #132563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kubelet: remove legacy log symlinks #132563

wants to merge 1 commit into from

Conversation

yujuhong
Copy link
Contributor

@yujuhong yujuhong commented Jun 26, 2025 •
edited
Loading

These symlinks were added for backward compatibility when the CRI log paths were first introduced. All the cluster logging tools are expected to be changed to use the new log paths a long time ago. Removing the legacy links.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR is related to: N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Remove legacy "/var/log/containers" symlinks that were used for backward compatibility during the CRI log path transition

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 26, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from kannon92 and odinuge June 26, 2025 19:34
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yujuhong
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@yujuhong yujuhong force-pushed the rm-legacy branch 3 times, most recently from 3a3e5be to 2c44b50 Compare June 26, 2025 20:48
@yujuhong
kubelet: remove legacy log symlinks
e307674 
These symlinks were added for backward compatibility when the CRI log
paths were first introduced. All the cluster logging tools are expected
to be changed to use the new log paths a long time ago. Removing the
legacy links.
@yujuhong
Copy link
Contributor Author

/assign @tallclair

@tallclair
Copy link
Member

All the cluster logging tools are expected to be changed to use the new log paths a long time ago

Which tools were using these paths?

I think this should have a release note, in case anyone was depending on these log paths.

@tallclair
Copy link
Member

There's still a bunch of references to /var/log/containers in the cluster addon fluentd configuration: https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/fluentd-gcp/fluentd-gcp-configmap.yaml

Does that need to be updated (or removed)?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@tallclair tallclair

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yujuhong @k8s-ci-robot @tallclair