Skip to content

fix: Truncate too long Deployment name in RS name #132560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 27, 2025
Merged

fix: Truncate too long Deployment name in RS name #132560

merged 5 commits into from
Jun 27, 2025
+152 −1

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Jun 26, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

When generating a replica set name, truncate the deployment name if it is too long. This fixes #116447 that fails to create a replica set when a deployment name is too long.

Which issue(s) this PR is related to:

Fixes #116447

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a bug that fails to create a replica set when a deployment name is too long.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @hdp617. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Jun 26, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 26, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from atiratree and mimowo June 26, 2025 18:25
@hdp617
Copy link
Contributor Author

hdp617 commented Jun 26, 2025

@janetkuo @aaron-prindle Going with Option 1 as mentioned in #116447 (comment). Could you take a look? Thanks!

janetkuo
janetkuo reviewed Jun 26, 2025
View reviewed changes
janetkuo
janetkuo reviewed Jun 26, 2025
View reviewed changes
@janetkuo
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025
@aaron-prindle
Copy link
Contributor

/sig api-machinery
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2025
aaron-prindle
aaron-prindle reviewed Jun 26, 2025
View reviewed changes
aaron-prindle
aaron-prindle reviewed Jun 26, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2025
janetkuo
janetkuo reviewed Jun 27, 2025
View reviewed changes
@janetkuo
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 27, 2025
janetkuo
janetkuo reviewed Jun 27, 2025
View reviewed changes
janetkuo
janetkuo approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 548c1e7bee8b232b83aecad74dae8ed2a45c9c6f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hdp617, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@aaron-prindle
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit b2f27c0 into kubernetes:master Jun 27, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 27, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jun 27, 2025
KobayashiD27 pushed a commit to KobayashiD27/kubernetes that referenced this pull request Jun 30, 2025
@hdp617 @KobayashiD27
fix: Truncate too long Deployment name in RS name (kubernetes#132560)
5858a7a 
* fix: Truncate too long Deployment name in RS name

* fix: lint & adjust unit tests

* fix: use const for "-" & unit tests

* Add test case for very long hash

* Explicitly define expected deployment name portion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-prindle aaron-prindle aaron-prindle left review comments

@janetkuo janetkuo janetkuo approved these changes

@atiratree atiratree Awaiting requested review from atiratree

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@aaron-prindle aaron-prindle

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

Deployment names can be too long, such that ReplicaSet creation fails
4 participants
@hdp617 @k8s-ci-robot @janetkuo @aaron-prindle