Skip to content

Avoid killing kops etcd-manager #132557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

Avoid killing kops etcd-manager #132557

merged 1 commit into from
Jun 26, 2025
+1 −1

Conversation

dims
Copy link
Member

@dims dims commented Jun 26, 2025 •
edited
Loading

Looking at flakiness in:
https://testgrid.k8s.io/amazon-ec2-kops#ci-kubernetes-e2e-al2023-aws-disruptive-canary&width=20

image

looking at log snippets like this:

> Enter [It] should recover from SIGKILL - k8s.io/kubernetes/test/e2e/apimachinery/etcd_failure.go:73 @ 06/26/25 08:02:23.787
STEP: failing etcd - k8s.io/kubernetes/test/e2e/apimachinery/etcd_failure.go:99 @ 06/26/25 08:02:23.788
I0626 08:02:26.757498 15885 ssh.go:363] ssh [email protected]:22: command:   pgrep etcd | xargs -I {} sudo kill -9 {}
I0626 08:02:26.757522 15885 ssh.go:364] ssh [email protected]:22: stdout:    ""
I0626 08:02:26.757528 15885 ssh.go:365] ssh [email protected]:22: stderr:    "kill: sending signal to 29684 failed: No such process\nkill: sending signal to 29692 failed: No such process\n"
I0626 08:02:26.757534 15885 ssh.go:366] ssh [email protected]:22: exit code: 123
I0626 08:02:29.528536 15885 ssh.go:363] ssh [email protected]:22: command:   pgrep etcd | xargs -I {} sudo kill -9 {}
I0626 08:02:29.528563 15885 ssh.go:364] ssh [email protected]:22: stdout:    ""
I0626 08:02:29.528569 15885 ssh.go:365] ssh [email protected]:22: stderr:    "kill: sending signal to 49316 failed: No such process\nkill: sending signal to 49322 failed: No such process\n"
I0626 08:02:29.528572 15885 ssh.go:366] ssh [email protected]:22: exit code: 123
[FAILED] master exec command returned non-zero
In [It] at: k8s.io/kubernetes/test/e2e/apimachinery/etc

Looks like the code is assuming that it has to kill every process with etcd in the string, but since we have etcd-manager running in kops by default, we may be doing the wrong thing causing flakiness.

Let's try screening the etcd-manager process out and see if that stabilizes the test in this specific CI job.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Avoid killing kops etcd-manager
31667cc 
Signed-off-by: Davanum Srinivas <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims
Copy link
Member Author

dims commented Jun 26, 2025

/assign @aojea

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 26, 2025
@dims
Copy link
Member Author

dims commented Jun 26, 2025

/assign @upodroid @ameukam

@ameukam
Copy link
Member

ameukam commented Jun 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8797c019f416ed71d07a777c58c346562874513d

upodroid
upodroid approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b38dd71 into kubernetes:master Jun 26, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@ameukam ameukam

@aojea aojea

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @k8s-ci-robot @ameukam @upodroid @aojea