Skip to content

scheduler_perf: Set version emulation only when QueueingHints is disabled #132555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

scheduler_perf: Set version emulation only when QueueingHints is disabled #132555

merged 1 commit into from
Jun 29, 2025
+4 −1

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jun 26, 2025 •
edited
Loading

What type of PR is this?

/kind bug
/sig scheduling

What this PR does / why we need it:

Currently, scheduler_perf tests unconditionally emulate v1.33, preventing tests from using features introduced in v1.34 and later.

This PR modifies the version emulation logic to only emulate v1.33 when QueueingHints is explicitly disabled in test configuration.

  • Tests with SchedulerQueueingHints: false → v1.33 emulation (unchanged)
  • Tests with SchedulerQueueingHints: true → No emulation (can use v1.34+ features)
  • Tests without QueueingHints setting → No emulation (default behavior)

Which issue(s) this PR is related to:

Fixes #132482

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from dom4ha and kerthcet June 26, 2025 13:03
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 26, 2025
@macsko
Copy link
Member

macsko commented Jun 27, 2025

/test pull-kubernetes-scheduler-perf

@macsko
Copy link
Member

macsko commented Jun 27, 2025

Looks good

/approve

@macsko
Copy link
Member

macsko commented Jun 27, 2025

/assign @sanposhiho

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
sanposhiho
sanposhiho reviewed Jun 27, 2025
View reviewed changes
@utam0k utam0k force-pushed the scheduler-perf-emulate-versino branch from 0cd90db to f437aa4 Compare June 28, 2025 02:00
@utam0k utam0k requested a review from sanposhiho June 28, 2025 02:03
sanposhiho
sanposhiho approved these changes Jun 29, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb5f2b789d5721a4f3dac098f744c93b0a262e76

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, sanposhiho, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanposhiho
Copy link
Member

I don't think it's a big thing

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@sanposhiho: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

I don't think it's a big thing

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanposhiho
Copy link
Member

@utam0k can you remove the release note

@k8s-ci-robot k8s-ci-robot merged commit a57091c into kubernetes:master Jun 29, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 29, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 29, 2025
@utam0k
Copy link
Member Author

utam0k commented Jun 29, 2025

@utam0k can you remove the release note

Done 🙆‍♀️

@KobayashiD27
Copy link
Contributor

Tests without QueueingHints setting → No emulation (default behavior)

@utam0k
Thank you for your works.
It's a minor thing, but if map is empty, false is returned, so I think v1.33 will be executed in the default case.

@utam0k utam0k mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@dom4ha dom4ha Awaiting requested review from dom4ha

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

scheduler_perf: Set version emulation only when QueueingHints is disabled
5 participants
@utam0k @k8s-ci-robot @macsko @sanposhiho @KobayashiD27