tests: runtime units #132544
tests: runtime units #132544
Conversation
Signed-off-by: Alex Pana <[email protected]>
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @acpana. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
cc @yujuhong ok to test 🙏🏼 ? |
|
/ok-to-test |
| if !reflect.DeepEqual(result, tt.expected) { | ||
| t.Errorf("ParseContainerID(%q) = %v, want %v", tt.input, result, tt.expected) | ||
| } |
There was a problem hiding this comment.
There's some disagreement over this, but I generally prefer to use the testify assert library for test assertions. I'll leave it to you to decide.
| if !reflect.DeepEqual(result, tt.expected) { | |
| t.Errorf("ParseContainerID(%q) = %v, want %v", tt.input, result, tt.expected) | |
| } | |
| assert.Equal(t, tt.expected, result, "ParseContainerID(%q)", tt.input) |
The file should use a consistent style whichever you choose
|
/assign |
Signed-off-by: Alex Pana <[email protected]>
bd2169d to
43f6bd4
Compare
|
LGTM label has been added. Git tree hash: 273740d42cb3e81b4bcc6a33af106a5a01f1fd97
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acpana, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Similar to #132541, add unit test coverage over
runtime.goWhich issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
n/a