Hi @gemmahou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/assign @seans3

/ok-to-test

/triage accepted
/priority backlog

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gemmahou
Once this PR has been reviewed and has the lgtm label, please ask for approval from seans3. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Example of ignoring lint issue for checking return error code:

This looks good, and thanks for the tests. But if I understood the conversation in this issue correctly, I believe there should also be a warning if the --ignore-not-found flag is set when not getting a specific resource. In other words, it doesn't make sense to set the flag unless also retrieving a specific resource. Please let me know what you think.

I've updated the help message for this flag, but it will only show up when when running kubectl get -h. It makes sense to display a warning if the flag is used incorrectly.

@seans3 I uploaded db2b0f7 to add an additional warning message.

I attempted to validate kubectl cmds by analyzing args and flags for warning triggers. However, this proved overly complex due to the varied nature of kubectl cmds, for example, kubectl get service/frontend and kubectl get service,pods have same args counts, but only the former queries a specific resource. Furthermore, if the GET request successfully finds resource(s), even --ignore-not-found is set, the warning message may not be necessary.

The primary confusion seems to lie with the exit code when there's no output(not found) and no HTTP error. So I've added additional warning messages that appears in this specific scenario. I believe this will help clarify user confusion. Let me know WDYT and I will add additional test cases.