Skip to content

DRA: Implementation of Consumable Capacity (KEP-5075) #132522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DRA: Implementation of Consumable Capacity (KEP-5075) #132522

wants to merge 4 commits into from
+10,078 −8,439

Conversation

sunya-ch
Copy link

What type of PR is this?

/kind feature
/kind api-change

/sig scheduling
/sig node
/sig network
/wg device-management

What this PR does / why we need it:

Implementation of KEP-5075
https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/5075-dra-consumable-capacity

Which issue(s) this PR is related to:

Fixes kubernetes/enhancements#5075

Special notes for your reviewer:

Tests were executed with github actions on a different branch:

There are still discussion left from KEP PR (kubernetes/enhancements#5104) regarding some API updates.
The last commit contains changes added after KEP merge. I will manually amend API commit again after review.

Does this PR introduce a user-facing change?

- Add driver-owned fields in ResourceSlice to mark whether the device is shareable among multiple resource claims (or requests) and to specify how each capacity can be shared between different requests.
- Add user-owned fields in ResourceClaim to specify resource requirements against each device capacity.
- Add scheduler-owned field in ResourceClaim.Status to specify how much device capacity is reserved for a specific request.
- Add an additional identifier to ResourceClaim.Status for the device supports multiple allocations.
- Add a new constraint type to enforce uniqueness of specified attributes across all allocated devices.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/5075
- [Usage]: 
- [Other doc]: TBD (blog)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/network Categorizes an issue or PR as relevant to SIG Network. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sunya-ch!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sunya-ch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/code-generation area/dependency Issues or PRs related to dependency changes area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh, dchen1107 and a team June 25, 2025 04:18
@sunya-ch sunya-ch mentioned this pull request Jun 21, 2025
Open
4 tasks
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Jun 25, 2025
@ffromani
Copy link
Contributor

/ok-to-test
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunya-ch
Once this PR has been reviewed and has the lgtm label, please assign liggitt, x13n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunya-ch
Copy link
Author

/retest

utam0k
utam0k reviewed Jun 26, 2025
View reviewed changes
@sunya-ch
Copy link
Author

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2025
sunya-ch added 4 commits July 1, 2025 15:52
@sunya-ch
KEP-5075: API updates
52e2422 
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@sunya-ch
KEP-5075: generated codes from make update
e48b5fc 
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@sunya-ch
KEP 5075: implement scheduler
73f9fde 
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@sunya-ch
tmp: update APIs after KEP merge
06ba386 
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 1, 2025 •
edited
Loading

@sunya-ch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-linter-hints 06ba386 link false /test pull-kubernetes-linter-hints

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees
No one assigned
Labels
api-review Categorizes an issue or PR as actively needing an API review. area/code-generation area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
API Reviews
Status: No status
Dynamic Resource Allocation
Status: 👀 In review
SIG Node CI/Test Board
Status: Triage
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRA: Consumable Capacity
5 participants
@sunya-ch @k8s-ci-robot @k8s-triage-robot @ffromani @utam0k