modify the comment of DistributeCPUsAcrossCoresOption #132520
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Chunxia202410. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Chunxia202410 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Jeffwan , please review, thanks~ |
|
/ok-to-test |
|
Hi, thanks for the contribution. I understand this change is well intentioned (and I see from where it comes from) but I think it borders a trivial edit. It should preferably merged in a bigger cleanup PR if possible. |
Sure, thanks for your suggestion, I will check more~ |
0845b91 to
2d3d896
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Correct the description of the DistributeCPUsAcrossCoresOption function to avoid confusion of understanding.
Which issue(s) this PR is related to:
CPUSortingOptionPacked sorts CPUs in a packed manner, where CPUs are grouped by core before moving to the next core, resulting in packed cores, like: 0, 6, 2, 8, 4, 10, 1, 7, 3, 9, 5, 11, not like 0, 2, 4, 6, 8, 10, 1, 3, 5, 7, 9, 11.
CPUSortingOptionSpread sorts CPUs in a spread manner, where CPUs are spread across cores before moving to the next CPU, resulting in spread-out cores, like: 0, 2, 4, 6, 8, 10, 1, 3, 5, 7, 9, 11, not like 0, 6, 2, 8, 4, 10, 1, 7, 3, 9, 5, 11.