Skip to content

Update CCM image to v33.0.0 #132515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update CCM image to v33.0.0 #132515

wants to merge 1 commit into from
+1 −1

Conversation

gemmahou
Copy link

@gemmahou gemmahou commented Jun 24, 2025 •
edited
Loading

What type of PR is this?

Follow up of #130696 and comment #130696 (comment), update the test image for CCM component, new image is available

gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v33.0.0
From new CCM release https://github.com/kubernetes/cloud-provider-gcp/releases/tag/ccm%2Fv33.0.0

This may additionally solve kubernetes/cloud-provider-gcp#868

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @gemmahou!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @gemmahou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gemmahou
Once this PR has been reviewed and has the lgtm label, please assign mrhohn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mborsz and MrHohn June 24, 2025 20:32
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
@gemmahou
Copy link
Author

/assign @YifeiZhuang
/assign @aojea

@gemmahou gemmahou mentioned this pull request Jun 24, 2025
Open
@YifeiZhuang
Copy link

You probably have to promote the image first then update it here?
https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/RELEASE.md#promote-image

docker pull registry.k8s.io/cloud-provider-gcp/cloud-controller-manager:v33.0.0
Error response from daemon: manifest for registry.k8s.io/cloud-provider-gcp/cloud-controller-manager:v33.0.0 not found: manifest unknown: Failed to fetch "v33.0.0"

@gemmahou
Copy link
Author

gemmahou commented Jun 24, 2025 •
edited
Loading

You probably have to promote the image first then update it here? https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/RELEASE.md#promote-image

docker pull registry.k8s.io/cloud-provider-gcp/cloud-controller-manager:v33.0.0
Error response from daemon: manifest for registry.k8s.io/cloud-provider-gcp/cloud-controller-manager:v33.0.0 not found: manifest unknown: Failed to fetch "v33.0.0"

Thanks! I was aware of this, but I'm not 100% sure about publish-oss-images step. ccm v33.0.0 has been released in April, I'd like to double check have we published the image to staging bucket or Artifact Registry?

@YifeiZhuang
Copy link

You are right, there is no 33.0.0 image in staging bucket.
We need to use 33.1.0, which will only be generated after kubernetes/cloud-provider-gcp#873

@seans3
Copy link
Contributor

seans3 commented Jun 26, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

@gemmahou: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce 449b9e8 link true /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gemmahou gemmahou mentioned this pull request Jun 27, 2025
Merged
@aojea
Copy link
Member

aojea commented Jun 30, 2025

latest image in registry is kubernetes/k8s.io#7848 is v32.2.2 so you can only update to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@YifeiZhuang YifeiZhuang

@aojea aojea

Labels
area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gemmahou @k8s-ci-robot @YifeiZhuang @seans3 @aojea