chore: Remove vet target and associated script from Makefile and hack directory #132509
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @BenTheElder |
|
I didn't even know (or remember) that we have Can we simply remove it instead? |
| @@ -20,6 +20,44 @@ set -o pipefail | |||
|
|
|||
| KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/../.. | |||
|
|
|||
| # Ignore the usual golangci.yaml config because it would | |||
| # enable additional linters, then enable just "go vet". | |||
| "${KUBE_ROOT}/hack/verify-golangci-lint.sh" -c none -- --disable-all --enable=govet "$@" | |||
There was a problem hiding this comment.
--disable-all has been replaced with --default=none.
can not just adapt to the new flags?
There was a problem hiding this comment.
Updated. Thanks, this makes change clearer.
I also need to update the hack/verify-golangci-lint.sh, the config verification doesn't tolerate empty config while it provides the flag with "-c none" to accept none config.
|
+1 @pohly , we should probably remove it. @yongruilin would you mind doing this? thanks we should add a release note about the removal: /sig testing |
|
Updated to remove the vet target from Makefile. Not quite related, but I also need to update the hack/verify-golangci-lint.sh, the config verification doesn't tolerate empty config while it provides the flag with "-c none" to accept none config. |
|
LGTM label has been added. Git tree hash: 788acaa949ad2ba2a5c8fa7932f5bb8b83608ddb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, yongruilin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This PR removes broken
vettarget from Makefile.Which issue(s) this PR is related to:
Fixes: #132508
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: