Skip to content

Add json-patch v4 compatibility test #132499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

Add json-patch v4 compatibility test #132499

merged 2 commits into from
Jun 24, 2025

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 24, 2025

What type of PR is this?

/kind test

What this PR does / why we need it:

Marks json-patch v5 as an unwanted dependency update due to compatibility issues, and adds a unit test demonstrating currently allowed (out-of-spec) behavior that v4 allows which v5 breaks.

Which issue(s) this PR is related to:

xref

Special notes for your reviewer:

Includes / updates #129988

Does this PR introduce a user-facing change?

NONE

/sig architecture
/sig api-machinery
/cc @dims @skitt

skitt and others added 2 commits June 24, 2025 09:18
@skitt @liggitt
Add evanphx/json-patch/v5 to unwanted dependencies
2ca4ffe 
This comes up periodically; bumping to v5 introduces issues with
replace operations in JSON patches. k/k relies on non-RFC-compliant
operations which v5 no longer allows.

Signed-off-by: Stephen Kitt <[email protected]>
@liggitt
Add json-patch v4 compatibility test
d180fe2
@k8s-ci-robot k8s-ci-robot requested review from dims and skitt June 24, 2025 13:25
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

@liggitt: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind test

What this PR does / why we need it:

Marks json-patch v5 as an unwanted dependency update due to compatibility issues, and adds a unit test demonstrating currently allowed (out-of-spec) behavior that v4 allows which v5 breaks.

Which issue(s) this PR is related to:

xref

Special notes for your reviewer:

Includes / updates #129988

Does this PR introduce a user-facing change?

NONE

/sig architecture
/sig api-machinery
/cc @dims @skitt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 24, 2025
@liggitt liggitt mentioned this pull request Jun 24, 2025
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@liggitt
Copy link
Member Author

liggitt commented Jun 24, 2025

/kind bug
/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/apiserver kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 24, 2025
@liggitt liggitt mentioned this pull request Jun 24, 2025
Closed
@liggitt liggitt moved this from Triage to Waiting for dependency review in [sig-architecture] Dependency management Jun 24, 2025
@dims
Copy link
Member

dims commented Jun 24, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b9e85a1f6b09be4a7a81c9d0481e73349b6f74a

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d2a5a2 into kubernetes:master Jun 24, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 24, 2025
@github-project-automation github-project-automation bot moved this from Waiting for dependency review to Done in [sig-architecture] Dependency management Jun 24, 2025
This was referenced Jun 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@skitt skitt Awaiting requested review from skitt

Assignees

@dims dims

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
[sig-architecture] Dependency management
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @k8s-ci-robot @dims @BenTheElder @skitt