e2e: serial: node cpumanager parity with the old suite #132498
+235
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Initially we added minimal quota disablement e2e tests, but since the emergence of kubevirt/kubevirt#14965 it becames clear that is better to have full coverage. This PR restores coverage parity with the old test suite. Signed-off-by: Francesco Romani <[email protected]>
The `ginkgo.ContinueOnFailure` decorator serves the usecase of the new cpumanager tests perfectly: https://onsi.github.io/ginkgo/#failure-handling-in-ordered-containers """ You can override this behavior by decorating an Ordered container with ContinueOnFailure. This is useful in cases where Ordered is being used to provide shared expensive set up for a collection of specs. When ContinueOnFailure is set, Ginkgo will continue running specs even if an earlier spec in the Ordered container has failed. """ And this is exactly the case at hand. Previously, without this decorator, subsequent failures were masked, which is dangerous and not what we want. Signed-off-by: Francesco Romani <[email protected]>
3251144 to
3b0fd32
Compare
|
/triage accepted |
|
sig-node CI meeting 20250625: agreement to add reduced (not 1:1) coverage for cgroup v1 |
Thanks @ffromani , ping @pravk03 , @natasha41575 , @Chunxia202410 and @AnishShah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR aims completes (to the best to the author's knowledge) the feature parity of the new cpumanager testsuite with the old one. Most notably:
ContinueOnFailureto avoid this while still keeping the benefits of theOrderedsuite (see code comments for details)Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
With this PR merged I think the rewrite is complete because all the items I had in my TODO are addressed. We can now have the final go/no-go conversation
Previous work
Does this PR introduce a user-facing change?