Skip to content

KEP-5229: Add SchedulerAsyncAPICalls feature gate #132487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

KEP-5229: Add SchedulerAsyncAPICalls feature gate #132487

merged 1 commit into from
Jun 26, 2025
+16 −0

Conversation

macsko
Copy link
Member

@macsko macsko commented Jun 24, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds a new feature flag needed for kubernetes/enhancements#5229.

Which issue(s) this PR is related to:

Fixes #132486

KEP: kubernetes/enhancements#5229

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@macsko
Copy link
Member Author

macsko commented Jun 24, 2025

/cc @dom4ha @sanposhiho

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 24, 2025
@macsko
Copy link
Member Author

macsko commented Jun 24, 2025

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
sanposhiho
sanposhiho approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

from sig-scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c832d2caea39540287253642a863330483c7b278

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, sanposhiho, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@lmktfy
Copy link

lmktfy commented Jun 26, 2025

Are we 100% sure this doesn't need a changelog entry?

@macsko
Copy link
Member Author

macsko commented Jun 26, 2025

Are we 100% sure this doesn't need a changelog entry?

Wouldn't it be better to add a changelog entry to PR that relies on this gate and mention it there?

@k8s-ci-robot k8s-ci-robot merged commit bc84914 into kubernetes:master Jun 26, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@dom4ha dom4ha Awaiting requested review from dom4ha

@MikeZappa87 MikeZappa87 Awaiting requested review from MikeZappa87

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

KEP-5229: Create SchedulerAsyncAPICalls feature flag
5 participants
@macsko @k8s-ci-robot @wojtek-t @lmktfy @sanposhiho