Improve containers lifecycle test output parsing #132485
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2 |
|
/priority important-soon |
|
/hold Have to look into this again. |
|
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2 |
This should fix the following test when running it with CRI-O: ``` [It] [sig-node] [Feature:SidecarContainers] [Serial] Containers Lifecycle when A node running restartable init containers reboots should restart the containers in right order with the proper phase after the node reboot ``` The issue is that we have prefixed "unable to retrieve container logs for …" outputs in the message to be parsed. We now skip that part and leave the current behavior untouched. Signed-off-by: Sascha Grunert <[email protected]>
c295375 to
0028ea8
Compare
|
/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2 |
|
Tests are green now /unhold |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2d5ab4246fb07c74e8b047e6477fd359d9bdfb9e
|
|
/approve thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This should fix the following test when running it with CRI-O:
The issue is that we have prefixed "unable to retrieve container logs for …" outputs in the message to be parsed. We now skip that part and leave the current behavior untouched.
Which issue(s) this PR is related to:
Refers to #131184
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: