apiserver/cacher: properly wire listwatch options to the listwatcher #132479
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @wojtek-t |
| } | ||
| } | ||
| createdPod := &example.Pod{} | ||
| key := computePodKey(createdPod) |
There was a problem hiding this comment.
The key is now computed from the empty pod - this seems wrong.
Lets do sth like:
pod := makePodFn()
key := computePodKey(pod)
createdPod := &example.Pod{}
...
bc1ecf8 to
1e2764f
Compare
we could wrap the |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 10e9c2e3f9a988debad27d4491e77326b055c3bb
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1e2764f to
dce69af
Compare
let's try wrapping. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 2f83892c4894f8ff085d35feb9192d595b8d4366
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: