-
Notifications
You must be signed in to change notification settings - Fork 40.9k
Fix DaemonSet misscheduled status not updating on node taint changes #132477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: xigang <[email protected]>
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xigang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a bug in the DaemonSet controller where the
NumberMisscheduled
status field does not get updated when node properties (labels or taints) change, leading to incorrect DaemonSet status reporting.Problem:
The
syncNodeUpdate
function in the DaemonSet controller has insufficient trigger conditions that only handle pod creation and deletion scenarios:This misses the critical third scenario where pods are already scheduled but their scheduling legitimacy changes due to node updates (e.g., when taints are added/removed).
Specific scenario that fails:
Solution:
Expand the trigger conditions to ensure any DaemonSet that has a relationship with the updated node (either should run on it or already has pods on it) gets resynced:
This ensures that DaemonSet status fields like
NumberMisscheduled
,CurrentNumberScheduled
, etc., are recalculated whenever node properties change.Which issue(s) this PR is related to:
Fixes #132459
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: