Skip to content

Fix DaemonSet misscheduled status not updating on node taint changes #132477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xigang
Copy link
Member

@xigang xigang commented Jun 24, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a bug in the DaemonSet controller where the NumberMisscheduled status field does not get updated when node properties (labels or taints) change, leading to incorrect DaemonSet status reporting.

Problem:
The syncNodeUpdate function in the DaemonSet controller has insufficient trigger conditions that only handle pod creation and deletion scenarios:

// Before: Only handles create/delete scenarios
if (shouldRun && !scheduled) || (!shouldContinueRunning && scheduled) {
    dsc.enqueueDaemonSet(ds)
}

This misses the critical third scenario where pods are already scheduled but their scheduling legitimacy changes due to node updates (e.g., when taints are added/removed).

Specific scenario that fails:

  1. A DaemonSet pod gets scheduled on a node before the node is tainted as "not-ready"
  2. When the node becomes ready and the taint is removed, the pod transitions from "misscheduled" to "correctly scheduled"
  3. However, the DaemonSet status is not updated because the current logic doesn't trigger a sync for this state transition
  4. The pod remains incorrectly flagged as misscheduled in the DaemonSet status

Solution:
Expand the trigger conditions to ensure any DaemonSet that has a relationship with the updated node (either should run on it or already has pods on it) gets resynced:

// After: Handles all scenarios including state transitions
if shouldRun || scheduled {
    dsc.enqueueDaemonSet(ds)
}

This ensures that DaemonSet status fields like NumberMisscheduled, CurrentNumberScheduled, etc., are recalculated whenever node properties change.

Which issue(s) this PR is related to:

Fixes #132459

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xigang
Once this PR has been reviewed and has the lgtm label, please assign janetkuo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xigang
Copy link
Member Author

xigang commented Jun 24, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2025
@xigang
Copy link
Member Author

xigang commented Jun 24, 2025

cc @wojtek-t @soltysh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

DaemonSet wrongfully reported as misscheduled on added node
2 participants