Skip to content

feature(kubectl): support --all and --all-namespaces flags for kubectl rollout restart #132476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature(kubectl): support --all and --all-namespaces flags for kubectl rollout restart #132476

wants to merge 1 commit into from

Conversation

googs1025
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • support --all and --all-namespaces flags for kubectl rollout restart

Which issue(s) this PR is related to:

fix: kubernetes/kubectl#1751

Special notes for your reviewer:

Does this PR introduce a user-facing change?

support --all and --all-namespaces flags for kubectl rollout restart

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2025
@googs1025 googs1025 marked this pull request as draft June 24, 2025 05:17
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jun 24, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Jun 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: googs1025
Once this PR has been reviewed and has the lgtm label, please assign seans3 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ardaguclu and seans3 June 24, 2025 05:17
@googs1025
Copy link
Member Author

googs1025 commented Jun 24, 2025 •
edited
Loading

~~ TODO: add more unit test ~~

@googs1025 googs1025 force-pushed the rollout/restart/feature branch from 936a7cc to 36eb16b Compare June 24, 2025 05:32
@googs1025
Copy link
Member Author

/retest

@googs1025 googs1025 force-pushed the rollout/restart/feature branch from 36eb16b to 8eed7ab Compare June 24, 2025 06:24
@googs1025
Copy link
Member Author

/retest

@googs1025 googs1025 force-pushed the rollout/restart/feature branch 3 times, most recently from 12ce395 to 8087361 Compare June 28, 2025 05:52
@googs1025 googs1025 marked this pull request as ready for review June 28, 2025 05:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mpuckett159 June 28, 2025 05:53
@googs1025 googs1025 force-pushed the rollout/restart/feature branch from 8087361 to 6b8603f Compare June 28, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@seans3 seans3 Awaiting requested review from seans3

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

Assignees
No one assigned
Labels
area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG CLI
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for kubectl rollout restart --all --all-namespaces
2 participants
@googs1025 @k8s-ci-robot