Skip to content

validation: skip unsupported pod-level resources during resource validation #132475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

validation: skip unsupported pod-level resources during resource validation #132475

wants to merge 2 commits into from
+59 −3

Conversation

rakshekaraj
Copy link

@rakshekaraj rakshekaraj commented Jun 24, 2025 •
edited
Loading

This PR updates validateResourceRequirements to skip validation for pod-level resource names that are not listed in supportedPodLevelResources.

Problem

Currently, the scheduler performs validation against all specified resource names, including unknown or vendor-specific pod-level resource names. This can cause unnecessary validation errors and block scheduling for valid but unsupported resource types.

Solution

This change filters out unsupported pod-level resource names during validation.
Resources not explicitly listed in supportedPodLevelResources are ignored, avoiding disruptive validation errors.

Tests

  • Unit tests added to ensure:
    • Unsupported resource names are skipped.
    • Supported resource names continue to be validated as before.
    • No regression in existing validation logic.

Release Note

Skip unsupported pod-level resource names during validation to avoid errors with custom or vendor-specific resources.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 24, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @rakshekaraj!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @rakshekaraj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rakshekaraj
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 24, 2025
@rakshekaraj rakshekaraj force-pushed the pod-resource-validation branch from 829f3a2 to 31fcc24 Compare June 24, 2025 05:53
@rakshekaraj
Copy link
Author

/recheck

@rakshekaraj
Copy link
Author

/cla recheck

@rakshekaraj rakshekaraj force-pushed the pod-resource-validation branch from 31fcc24 to 9e283ce Compare June 24, 2025 06:00
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG Apps Jun 24, 2025
@rakshekaraj rakshekaraj deleted the pod-resource-validation branch June 24, 2025 06:27
@rakshekaraj rakshekaraj reopened this Jun 24, 2025
@github-project-automation github-project-automation bot moved this from Closed to In Progress in SIG Apps Jun 24, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2025
@rakshekaraj
Copy link
Author

Hi @deads2k @pwittrock, would appreciate a review whenever convenient! This PR skips unsupported pod-level resources during validation to avoid errors with custom resources. Thanks so much!

@toVersus
Copy link
Contributor

/hold

As discussed in #132449 (comment), there's already a PR open for the fix and we're currently discussing who will handle it, so could you hold off for now? In addition, the code and tests in this PR are incomplete, so it can't be merged as is.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Apps
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakshekaraj @k8s-ci-robot @toVersus