Skip to content

[FG:InPlacePodVerticalScaling] Add a feature gate for in-place resize with static memory manager policy support #132473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[FG:InPlacePodVerticalScaling] Add a feature gate for in-place resize with static memory manager policy support #132473

wants to merge 2 commits into from
+341 −17

Conversation

pravk03
Copy link

@pravk03 pravk03 commented Jun 24, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is to introduce a separate feature gate to enable/disable support for static memory policy. Along with introducing a new feature gate, a check is added to identify if CPU or Memory is being resized and check the appropriate feature gate.

Which issue(s) this PR is related to:

#132466

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Ensure memory resizing for Guaranteed QOS pods on static Memory policy configured is gated by `InPlacePodVerticalScalingExclusiveMemory` (defaults to `false`).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @pravk03. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and dims June 24, 2025 00:34
@pravk03 pravk03 changed the title [FG:InPlacePodVerticalScaling] Add a feature gate for in-place resize with static memory policy support [FG:InPlacePodVerticalScaling] Add a feature gate for in-place resize with static memory manager policy support Jun 24, 2025
@pravk03 pravk03 marked this pull request as ready for review June 24, 2025 19:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dashpole June 24, 2025 19:35
@pravk03
Copy link
Author

pravk03 commented Jun 24, 2025

/assign @tallclair
/cc @natasha41575

natasha41575
natasha41575 reviewed Jun 24, 2025
View reviewed changes
@pravk03 pravk03 force-pushed the ippr-static-mem-featuregate branch from 74129f2 to 0b359bd Compare June 25, 2025 16:10
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 25, 2025
@pravk03 pravk03 force-pushed the ippr-static-mem-featuregate branch from 0b359bd to cd315c5 Compare June 25, 2025 16:14
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pravk03
Once this PR has been reviewed and has the lgtm label, please ask for approval from tallclair. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pravk03
Copy link
Author

pravk03 commented Jun 25, 2025

/cc @esotsal

@k8s-ci-robot k8s-ci-robot requested a review from esotsal June 25, 2025 16:33
@pravk03 pravk03 force-pushed the ippr-static-mem-featuregate branch 2 times, most recently from 87105d6 to 0390d1e Compare June 25, 2025 20:42
esotsal
esotsal reviewed Jun 26, 2025
View reviewed changes
@esotsal
Copy link
Contributor

esotsal commented Jun 26, 2025

Thanks @pravk03 overall looks good to me , beside my comment/suggestion with regard naming of the feature gate. I noticed also that you have added refactoring to add node config in test case and an additional check if pod/container needs resize, nice additions , thanks for that!

@yongruilin
Copy link
Contributor

/remove-sig api-machinery
@tallclair should have permission as feature-approver

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 26, 2025
@pravk03
Create separate feature gates for static CPU Manager and static Memor…
4b02bc0 
…y Manager support.

New gate "InPlacePodVerticalScalingExclusiveMemory" is off by default,
but can be enabled to unblock development of Static Memory Manager policy
alongside InPlacePodVerticalScaling.
@pravk03 pravk03 force-pushed the ippr-static-mem-featuregate branch from 0390d1e to 5d4a9bf Compare June 27, 2025 00:14
esotsal
esotsal reviewed Jun 27, 2025
View reviewed changes
@pravk03 pravk03 force-pushed the ippr-static-mem-featuregate branch from 5d4a9bf to 72bfac4 Compare June 27, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@esotsal esotsal esotsal left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@dims dims Awaiting requested review from dims

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@tallclair tallclair

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
SIG Node: In Place Pod Vertical Scaling
Status: No status
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pravk03 @k8s-ci-robot @esotsal @yongruilin @natasha41575 @tallclair