Skip to content

Cleanup: Remove redundant detail messages in field.Required #132472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Cleanup: Remove redundant detail messages in field.Required #132472

merged 1 commit into from
Jul 1, 2025
+47 −47

Conversation

xiaoweim
Copy link
Contributor

@xiaoweim xiaoweim commented Jun 23, 2025 •
edited by thockin
Loading

What type of PR is this?

/kind cleanup
/sig architecture

What this PR does / why we need it:

This pull request addresses issue #111698 by removing redundant detail messages from field.Required calls throughout the repository.

Many validation checks used messages that simply stated a field was "required" or "must be set". This is unnecessary, as the error type field.Required already conveys that information.

Which issue(s) this PR is related to:

xref 111698

Special notes for your reviewer:

Here is the list of all the instances of field.Required: https://gist.github.com/xiaoweim/cf96a57089939ebed8d9dfcffcd0b991

Does this PR introduce a user-facing change?

Simplied validation error message for required fields by removing redundant messages.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jun 23, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 23, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 23, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @xiaoweim!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @xiaoweim. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from apelisse and bart0sh June 23, 2025 23:30
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jun 23, 2025
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 23, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 23, 2025
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jun 23, 2025
yongruilin
yongruilin reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@yongruilin yongruilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue!
I left a small question.
Could you also tidy up the PR description a bit (the issue link section)?

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@xiaoweim xiaoweim force-pushed the validation-cleanup branch from c62c974 to 49ed6ee Compare June 24, 2025 20:15
@xiaoweim
Copy link
Contributor Author

/test pull-kubernetes-unit-windows-master

@xiaoweim xiaoweim requested a review from yongruilin June 24, 2025 22:07
@yongruilin
Copy link
Contributor

/retest

pohly
pohly reviewed Jun 25, 2025
View reviewed changes
@xiaoweim xiaoweim force-pushed the validation-cleanup branch 4 times, most recently from f5a927d to 034123d Compare June 26, 2025 21:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2025
@xiaoweim xiaoweim force-pushed the validation-cleanup branch from 034123d to 8632257 Compare June 26, 2025 21:26
@xiaoweim xiaoweim requested a review from pohly June 26, 2025 21:44
@yongruilin
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f4523be69e7e6a8c75f725931fab3958c3d51d7a

@xiaoweim
Copy link
Contributor Author

/assign @thockin

thockin
thockin reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, xiaoweim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit eb1b603 into kubernetes:master Jul 1, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@apelisse apelisse Awaiting requested review from apelisse

@bart0sh bart0sh Awaiting requested review from bart0sh

@aojea aojea Awaiting requested review from aojea

@aaron-prindle aaron-prindle Awaiting requested review from aaron-prindle

@yongruilin yongruilin Awaiting requested review from yongruilin

@pohly pohly Awaiting requested review from pohly

Assignees

@thockin thockin

@yongruilin yongruilin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Apps
Status: Done
SIG Auth
Status: Closed / Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@xiaoweim @k8s-ci-robot @aaron-prindle @k8s-triage-robot @yongruilin @pohly @thockin