feat(validation-gen): support validation ratcheting for list #132469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yongruilin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @aaron-prindle @jpbetz @thockin |
6874397 to
fb477ed
Compare
Co-authored-by: Yongrui Lin <[email protected]>
- identify listtype=set and store in shared listMetadata - pass in cmp for lookup in eachVal - add validate.SemanticDeepEqual as cmpArg for non-comparable args
Co-authored-by: Yongrui Lin <[email protected]>
- Only use simple comparison for built-in types
- Introduced SliceFalselyComparableField to Struct and ImmutableStruct - Updated validation logic to handle unique and deep equality checks for falsely comparable structs - Enhanced test cases to validate the new field's behavior
- Updated EachSliceVal to support a match function and an equivalence comparison function, enhancing its flexibility for validation. - Adjusted related validation logic and tests to utilize the new structure, ensuring backward compatibility and improved validation accuracy.
fb477ed to
2cf7f44
Compare
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support validation ratcheting for list.
The commits cherry-picked here, have been reviewed and merged in dev repo.
Which issue(s) this PR is related to:
Ref:
Special notes for your reviewer:
The related KEP has been merged:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: