Skip to content

ci: update test image base: nginx, nginx-new #132442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

ci: update test image base: nginx, nginx-new #132442

merged 1 commit into from
Jun 24, 2025
+12 −12

Conversation

ylink-lfs
Copy link
Contributor

@ylink-lfs ylink-lfs commented Jun 22, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup
/sig testing

What this PR does / why we need it:

Test packages update purpose

Which issue(s) this PR is related to:

Update the BASEIMAGEs to the latest version for test/images

Special notes for your reviewer:

  • nginx and nginx-new for linux: Selected the most recent 2 versions from dockerhub.
  • all images for windows didn't found newer version in previously used image source.

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Nginx Image for Linux: https://hub.docker.com/_/nginx
Nginx Image for Windows: https://hub.docker.com/r/claudiubelu/nginx/tags

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 22, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ylink-lfs!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ylink-lfs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ylink-lfs
Copy link
Contributor Author

ylink-lfs commented Jun 22, 2025 •
edited
Loading

/cc @mkumatag

mkumatag
mkumatag suggested changes Jun 23, 2025
View reviewed changes
@ylink-lfs ylink-lfs force-pushed the ci/test_image_update branch from 4fccf17 to c2f0131 Compare June 23, 2025 06:31
pacoxu
pacoxu reviewed Jun 23, 2025
View reviewed changes
@ylink-lfs ylink-lfs force-pushed the ci/test_image_update branch from c2f0131 to d4ba77b Compare June 23, 2025 09:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2025
@ylink-lfs ylink-lfs changed the title ci: update test image base: nginx, nginx-new and redis ci: update test image base: nginx, nginx-new Jun 23, 2025
@ylink-lfs ylink-lfs force-pushed the ci/test_image_update branch from d4ba77b to 59dd2bd Compare June 23, 2025 09:58
@ylink-lfs ylink-lfs requested review from pacoxu and mkumatag June 23, 2025 09:58
mkumatag
mkumatag approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 753085b265c933f334d7b1cfd7e0c68251d3793e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, ylink-lfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@mkumatag
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2025
@mkumatag mkumatag mentioned this pull request Jun 24, 2025
Open
23 tasks
@k8s-ci-robot k8s-ci-robot merged commit 7521de1 into kubernetes:master Jun 24, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 24, 2025
@ylink-lfs ylink-lfs deleted the ci/test_image_update branch June 25, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@dims dims Awaiting requested review from dims

@justaugustus justaugustus Awaiting requested review from justaugustus

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@ylink-lfs @k8s-ci-robot @mkumatag @pacoxu