Skip to content

Promote sig-storage feature MutableCSINodeAllocatableCount to Beta #132429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote sig-storage feature MutableCSINodeAllocatableCount to Beta #132429

wants to merge 1 commit into from
+29 −23

Conversation

torredil
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR promotes the MutableCSINodeAllocatableCount feature to Beta.

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#4876

Special notes for your reviewer:

This PR also enables the feature gate by default. As a reminder, the functionality introduced in the enhancement requires opt-in by the CSI Driver.

For reactive CSINode updates, see:

kubernetes/pkg/volume/csi/csi_plugin.go

Line 208 in 0f478e5

return

For periodic CSINode updates, see:

kubernetes/pkg/volume/csi/csi_node_updater.go

Line 143 in 0f478e5

return

Does this PR introduce a user-facing change?

Promote MutableCSINodeAllocatableCount to Beta.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2025
@k8s-ci-robot k8s-ci-robot requested review from cici37 and liggitt June 20, 2025 14:03
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2025
@torredil torredil mentioned this pull request Jun 20, 2025
Open
8 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: torredil
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 20, 2025 •
edited
Loading

@torredil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-storage-slow 6835bfa link false /test pull-kubernetes-e2e-gce-storage-slow

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RainbowYHT
Copy link

感謝🙏！有問題的地方有的也做好了相關的修復合並！謝謝你們

@pacoxu
Copy link
Member

pacoxu commented Jun 23, 2025

/retest
/cc @gnufied @msau42

@k8s-ci-robot k8s-ci-robot requested review from gnufied and msau42 June 23, 2025 07:38
@pacoxu
Copy link
Member

pacoxu commented Jun 23, 2025

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 23, 2025
@pacoxu
Copy link
Member

pacoxu commented Jun 23, 2025

/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-gce-storage-slow

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@torredil
Copy link
Member Author

cc: @gnufied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 Awaiting requested review from cici37

@liggitt liggitt Awaiting requested review from liggitt

@gnufied gnufied Awaiting requested review from gnufied

@msau42 msau42 Awaiting requested review from msau42

Assignees
No one assigned
Labels
area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@torredil @k8s-ci-robot @RainbowYHT @pacoxu @k8s-triage-robot