Skip to content

remove kvh.exec #132412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove kvh.exec #132412

wants to merge 1 commit into from
+0 −3

Conversation

liyuerich
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

exec is unused, need to be cleaned up

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2025
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and matthyx June 20, 2025 02:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liyuerich
Once this PR has been reviewed and has the lgtm label, please assign yujuhong for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jun 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 20, 2025
@liyuerich
Copy link
Contributor Author

/test pull-kubernetes-unit-windows-master

1 similar comment
@liyuerich
Copy link
Contributor Author

/test pull-kubernetes-unit-windows-master

@liyuerich
Copy link
Contributor Author

https://prow.k8s.io/job-history/gs/kubernetes-ci-logs/pr-logs/directory/pull-kubernetes-unit-windows-master

not sure if it is flaky test, will open an issue

@liyuerich
Copy link
Contributor Author

/cc @carlory

@k8s-ci-robot k8s-ci-robot requested a review from carlory June 20, 2025 05:23
@carlory
Copy link
Member

carlory commented Jun 20, 2025

/test pull-kubernetes-unit-windows-master

@liyuerich
Copy link
Contributor Author

flaking test #132424 , wait fix merged.

@carlory
Copy link
Member

carlory commented Jun 23, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a1e5435ccd98689ccc036870d5be4c8fdc344a13

@liyuerich
Copy link
Contributor Author

/test pull-kubernetes-unit-windows-master

@liyuerich
remove kvh.exec
cfeab03 
Signed-off-by: liyuerich <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@carlory
Copy link
Member

carlory commented Jun 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 917f9c036bc914a0e7b72020620179a5bd87cba2

@bart0sh
Copy link
Contributor

bart0sh commented Jun 24, 2025

/triage accepted

/assign @SergeyKanzhelev @mrunalp
for approval

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 24, 2025
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node: code and documentation PRs Jun 24, 2025
@liyuerich
Copy link
Contributor Author

/triage accepted

/assign @SergeyKanzhelev @mrunalp for approval

@SergeyKanzhelev @mrunalp , could you help to approve? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@matthyx matthyx Awaiting requested review from matthyx

@carlory carlory Awaiting requested review from carlory

Assignees

@mrunalp mrunalp

@SergeyKanzhelev SergeyKanzhelev

@carlory carlory

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Status: Needs Approver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liyuerich @k8s-ci-robot @carlory @bart0sh @mrunalp @SergeyKanzhelev