Skip to content

imageMaximumGCAge download /remove loop with CreateContainerConfigError state #132411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

imageMaximumGCAge download /remove loop with CreateContainerConfigError state #132411

wants to merge 1 commit into from

Conversation

aryasoni98
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes an issue where images used by containers in error states (such as CreateContainerConfigError) were repeatedly garbage collected and re-downloaded, causing unnecessary network traffic and resource usage.
The image garbage collection logic now excludes containers that are not actually using their images (i.e., not in "running" or "created" state), preventing images referenced by error-state containers from being considered "in use."
This avoids the download/remove loop and reduces unnecessary image pulls.

Which issue(s) this PR is related to:

Fixes #132403

Special notes for your reviewer:

  • The fix introduces a helper function to determine if a container is actually using its image.
  • Unit tests and image GC tests have been updated to reflect the new logic.
  • Please review the test changes to ensure they align with the intended behavior.

Does this PR introduce a user-facing change?

Kubelet: Fixes an issue where images used by containers in error states (e.g., CreateContainerConfigError) were repeatedly garbage collected and re-downloaded, causing high network traffic. Images are now only considered "in use" if the container is actually running or created.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @aryasoni98. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aryasoni98
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from bart0sh and mtaufen June 20, 2025 01:05
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2025
bart0sh
bart0sh reviewed Jun 24, 2025
View reviewed changes
pkg/kubelet/images/image_gc_manager.go
@@ -256,6 +280,16 @@ func (im *realImageGCManager) detectImages(ctx context.Context, detectTime time.
// Make a set of images in use by containers.
for _, pod := range pods {
for _, container := range pod.Containers {
// Skip containers that are not actually using the image
// This includes containers in error states like CreateContainerConfigError
if !isContainerActuallyUsingImage(container) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that if image is not used by any container it will never be gc-ed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart0sh No, that's not the case.

If an image is not used by any container, it is eligible for garbage collection according to the usual image GC policies (such as imageMaximumGCAge and disk pressure thresholds).

This change only ensures that images used by containers in error states (like CreateContainerConfigError) are not considered "in use" and can be garbage collected if not used elsewhere.

Let me know if you have any other questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh bart0sh left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

imageMaximumGCAge download /remove loop with CreateContainerConfigError state
3 participants
@aryasoni98 @k8s-ci-robot @bart0sh