Skip to content

Fix [Failing test] [sig-node] [Feature:GPUDevicePlugin] [Serial]-related tests #132399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Fix [Failing test] [sig-node] [Feature:GPUDevicePlugin] [Serial]-related tests #132399

merged 1 commit into from
Jun 24, 2025

Conversation

carlory
Copy link
Member

@carlory carlory commented Jun 19, 2025 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

After #122384 is merged, these tests re-added by #127456 is failing.

error message:

{ failed [FAILED] Timed out after 600.001s.
Expected success, but got an error:
    <*errors.errorString | 0xc001481e00>: 
    nvidia GPUs not available on Node: "bootstrap-e2e-master"
    {
        s: "nvidia GPUs not available on Node: \"bootstrap-e2e-master\"",
    }
In [It] at: k8s.io/kubernetes/test/e2e/node/gpu.go:393 @ 06/18/25 13:46:30.284
}

According to the source of resurrected code, the master node shouldn't consider as a gpu node but re-added code doesn't meet this requirement.

- apiVersion: v1
  kind: Node
  metadata:
    annotations:
      node.alpha.kubernetes.io/ttl: "0"
      volumes.kubernetes.io/controller-managed-attach-detach: "true"
    creationTimestamp: "2025-06-18T11:36:09Z"
    labels:
      beta.kubernetes.io/arch: amd64
      beta.kubernetes.io/instance-type: e2-standard-2
      beta.kubernetes.io/os: linux
      cloud.google.com/metadata-proxy-ready: "true"
      failure-domain.beta.kubernetes.io/region: us-central1
      failure-domain.beta.kubernetes.io/zone: us-central1-b
      kubernetes.io/arch: amd64
      kubernetes.io/hostname: bootstrap-e2e-master
      kubernetes.io/os: linux
      node.kubernetes.io/instance-type: e2-standard-2
      topology.kubernetes.io/region: us-central1
      topology.kubernetes.io/zone: us-central1-b
    name: bootstrap-e2e-master
    resourceVersion: "726"
    uid: 36054c32-3c5c-462f-a8e6-880068c673f4
  spec:
    podCIDR: 10.64.0.0/24
    podCIDRs:
    - 10.64.0.0/24
    providerID: gce://k8s-infra-e2e-boskos-gpu-03/us-central1-b/bootstrap-e2e-master
    taints:
    - effect: NoSchedule
      key: node-role.kubernetes.io/control-plane
    - effect: NoSchedule
      key: node.kubernetes.io/unschedulable
    unschedulable: true

The master node doesn't have node-role.kubernetes.io/control-plane label.

After #122384 is merged and flags+=" --register-schedulable=false is removed. This is the reason why the test is failing.

Which issue(s) this PR is related to:

Fixes #132397

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 19, 2025
@carlory
Copy link
Member Author

carlory commented Jun 19, 2025

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 19, 2025 07:45
@carlory
Copy link
Member Author

carlory commented Jun 19, 2025

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@kannon92
Copy link
Contributor

CI passes. Code LGTM!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 371982f6fcdb8397fd407b2f44b3cd39e40d5613

@carlory
Copy link
Member Author

carlory commented Jun 20, 2025

/assign @klueska
for approval

@carlory
Copy link
Member Author

carlory commented Jun 23, 2025

/assign @SergeyKanzhelev @hakuna-matatah
for approval

kannon92
kannon92 reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ffromani

@k8s-ci-robot k8s-ci-robot requested a review from ffromani June 23, 2025 03:12
@pacoxu
Copy link
Member

pacoxu commented Jun 24, 2025

/lgtm
/approve
/assign @pohly @SergeyKanzhelev @klueska
https://testgrid.k8s.io/sig-release-master-blocking#gce-device-plugin-gpu-master
release blocking CI failed for a week
@kubernetes/release-team-release-signal

@pacoxu pacoxu mentioned this pull request Jun 24, 2025
Closed
@pohly
Copy link
Contributor

pohly commented Jun 24, 2025

/approve

I'm not sure about a helper method emitting log messages (limits its (re-)usability) but if that's what you want in this case then let's keep that.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, pacoxu, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 29ed1fb into kubernetes:master Jun 24, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 24, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Jun 24, 2025
@carlory carlory deleted the fix-132397 branch June 24, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@wzshiming wzshiming Awaiting requested review from wzshiming

@dims dims Awaiting requested review from dims

@ffromani ffromani Awaiting requested review from ffromani

Assignees

@pohly pohly

@klueska klueska

@pacoxu pacoxu

@kannon92 kannon92

@SergeyKanzhelev SergeyKanzhelev

@hakuna-matatah hakuna-matatah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.

[Failing test] [sig-node] [Feature:GPUDevicePlugin] [Serial]-related tests
8 participants
@carlory @k8s-ci-robot @kannon92 @pacoxu @pohly @klueska @SergeyKanzhelev @hakuna-matatah