Skip to content

feat: add PreBindPreFlight and implement in in-tree plugins #132391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add PreBindPreFlight and implement in in-tree plugins #132391

wants to merge 1 commit into from

Conversation

sanposhiho
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • add PreBindPreFlight to PreBind interface
  • implement it in in-tree plugins

Which issue(s) this PR is related to:

Fixes #132382
Fixes #132389

Special notes for your reviewer:

Does this PR introduce a user-facing change?

New PreBindPreFlight function is added to PreBindPlugin interface. In-tree PreBind plugins now implement PreBindPreFlight function.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/5278-nominated-node-name-for-expectation

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from carlory and klueska June 18, 2025 22:15
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 18, 2025
sanposhiho
sanposhiho commented Jun 18, 2025
View reviewed changes
Copy link
Member Author

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

To go thru two reviews.

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@sanposhiho
Copy link
Member Author

/cc @macsko @dom4ha
/cc @carlory for the storage area

@k8s-ci-robot k8s-ci-robot requested review from macsko and dom4ha June 18, 2025 22:16
@k8s-ci-robot
Copy link
Contributor

@sanposhiho: GitHub didn't allow me to request PR reviews from the following users: for, the, area.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @macsko @dom4ha
/cc @carlory for the storage area

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanposhiho sanposhiho force-pushed the pre-bind-pre-flight branch 3 times, most recently from 7647629 to 91be785 Compare June 18, 2025 22:48
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jun 18, 2025
@sanposhiho sanposhiho force-pushed the pre-bind-pre-flight branch from 91be785 to 6b26921 Compare June 18, 2025 23:21
@carlory
Copy link
Member

carlory commented Jun 19, 2025

/retest

@sanposhiho sanposhiho force-pushed the pre-bind-pre-flight branch from 6b26921 to 7c15b12 Compare June 19, 2025 08:51
@carlory
Copy link
Member

carlory commented Jun 20, 2025

/lgtm
for the storage area

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e2284eece32f8ae95a0139903444c34e657d4a06

@pohly pohly moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Jun 23, 2025
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jun 25, 2025
macsko
macsko reviewed Jun 26, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@sanposhiho sanposhiho requested a review from macsko June 26, 2025 21:49
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@sanposhiho sanposhiho force-pushed the pre-bind-pre-flight branch from 2326628 to b267d47 Compare June 29, 2025 15:20
@sanposhiho
Copy link
Member Author

/retest

@macsko
Copy link
Member

macsko commented Jun 30, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e3a5d1cca1466b545f8f44549f77a9335df69f9f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: macsko, sanposhiho
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanposhiho
Copy link
Member Author

/unhold
got an approval from the approver. Although we need reviewers for other areas

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2025
macsko
macsko reviewed Jul 1, 2025
View reviewed changes
pkg/features/kube_features.go
@@ -1542,6 +1552,10 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
{Version: version.MustParse("1.30"), Default: true, PreRelease: featuregate.Beta},
},

NominatedNodeNameForExpectation: {
{Version: version.MustParse("1.34"), Default: false, PreRelease: featuregate.Beta},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{Version: version.MustParse("1.34"), Default: false, PreRelease: featuregate.Beta},
{Version: version.MustParse("1.34"), Default: true, PreRelease: featuregate.Beta},

test/compatibility_lifecycle/reference/versioned_feature_list.yaml
@@ -969,6 +969,12 @@
lockToDefault: false
preRelease: Beta
version: "1.30"
- name: NominatedNodeNameForExpectation
versionedSpecs:
- default: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- default: false
- default: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macsko macsko macsko left review comments

@carlory carlory Awaiting requested review from carlory

@klueska klueska Awaiting requested review from klueska

@dom4ha dom4ha Awaiting requested review from dom4ha

Assignees

@carlory carlory

@macsko macsko

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🏗 In progress
SIG Node CI/Test Board
Status: Archive-it
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEP-5278: Implement PreBindPreFlight in in-tree plugins KEP-5278: Implement PreBindPreFlight in PreBind interface
4 participants
@sanposhiho @k8s-ci-robot @carlory @macsko