Skip to content

Move recovery tests ga #132380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move recovery tests ga #132380

wants to merge 2 commits into from
+247 −96

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jun 18, 2025 •
edited
Loading

xref - kubernetes/enhancements#1790

Also adds additional tests for verifying quota after recovery.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from carlory and pohly June 18, 2025 20:01
@gnufied
Copy link
Member Author

gnufied commented Jun 18, 2025

/sig storage
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 18, 2025
@gnufied
Copy link
Member Author

gnufied commented Jun 18, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 18, 2025
carlory
carlory reviewed Jun 19, 2025
View reviewed changes
test/e2e/storage/csimock/csi_volume_expansion.go
@@ -396,7 +394,7 @@ var _ = utils.SIGDescribe("CSI Mock volume expansion", func() {
}
})

f.Context("Expansion with recovery", feature.RecoverVolumeExpansionFailure, framework.WithFeatureGate(features.RecoverVolumeExpansionFailure), func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature label RecoverVolumeExpansionFailure can be removed from https://github.com/kubernetes/kubernetes/blob/master/test/e2e/feature/feature.go#L367

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed now.

@carlory
Copy link
Member

carlory commented Jun 19, 2025

Can we remove this code block? https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/csi.go#L725-L727 because it is enabled by default according to testing-manifests/storage-csi/mock/csi-mock-driver-resizer.yaml

https://github.com/kubernetes-csi/external-resizer/blob/v1.13.1/pkg/features/features.go#L51

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2025
@gnufied gnufied force-pushed the move-recovery-tests-ga branch from 9203112 to a89038a Compare June 27, 2025 21:52
@gnufied gnufied force-pushed the move-recovery-tests-ga branch from a89038a to d67e793 Compare June 27, 2025 21:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2025
@gnufied
Copy link
Member Author

gnufied commented Jun 28, 2025

/retest

@gnufied
Copy link
Member Author

gnufied commented Jun 30, 2025

@carlory I believe I removed the block you linked. PTAL.

@carlory
Copy link
Member

carlory commented Jul 1, 2025

/lgtm
/assign @jsafrane

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ce8efddb460a2b99a6f7573321f7ecf584882fe9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory carlory left review comments

@pohly pohly Awaiting requested review from pohly

Assignees

@jsafrane jsafrane

@carlory carlory

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnufied @k8s-ci-robot @carlory @jsafrane