-
Notifications
You must be signed in to change notification settings - Fork 40.9k
flag: fix nil-ptr panic & typo messages #132365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
flag: fix nil-ptr panic & typo messages #132365
Conversation
### What changed * [RegisterWithTaintsVar](cci:2://file:///d:/Github/kubernetes/pkg/util/flag/flags.go:260:0-262:1) * Added nil-target checks in [Set](cci:1://file:///d:/Github/kubernetes/pkg/util/flag/flags.go:170:0-231:1) and [String](cci:1://file:///d:/Github/kubernetes/pkg/util/flag/flags.go:151:0-157:1); avoids panic when slice pointer isn’t pre-initialised. * [ReservedMemoryVar](cci:2://file:///d:/Github/kubernetes/pkg/util/flag/flags.go:165:0-168:1) * Closed missing parenthesis in error string. * Corrected spelling in three user-visible error messages. ### Why it matters * Prevents kubelet (and any consumer) from crashing during flag parsing if the `--register-with-taints` target slice wasn’t set up. * Clear, correctly-spelled errors make mis-configured `--reserved-memory` flags easier to diagnose. _No functional behaviour altered; only robustness and usability improved._
The committers listed above are authorized under a signed CLA. |
Welcome @mohiuddin-khan-shiam! |
Hi @mohiuddin-khan-shiam. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 61b492cd82fa3640b6126cd7fd32fae22639eab8
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mohiuddin-khan-shiam, SergeyKanzhelev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-notes-node |
/release-note-none not sure which one is right |
/assign @dims as per bot recommendation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
What changed
Why it matters
--register-with-taints
target slice wasn’t set up.--reserved-memory
flags easier to diagnose.No functional behaviour altered; only robustness and usability improved.