Skip to content

Promote KubeletTracing featuregate to GA #132341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Promote KubeletTracing featuregate to GA #132341

wants to merge 2 commits into from

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jun 16, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Promote the KubeletTracing featuregate to GA.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted the `KubeletTracing` feature gate to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Please use the following format for linking documentation:

cc @kubernetes/sig-instrumentation-leads @haircommander

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 16, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@dashpole
Copy link
Contributor Author

/sig node
/sig instrumentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 16, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 16, 2025
@dashpole dashpole marked this pull request as ready for review June 17, 2025 14:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims June 17, 2025 14:39
@dashpole
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@dashpole dashpole force-pushed the graduate_kubelet_tracing branch 2 times, most recently from ad5f6a4 to 9582658 Compare June 17, 2025 16:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubelet and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2025
@dashpole
Copy link
Contributor Author

@SergeyKanzhelev done in eb781f6

SergeyKanzhelev
SergeyKanzhelev approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ff56b7a3332d66e6e886d3ab71eb5f94eb70794f

@SergeyKanzhelev
Copy link
Member

/assign @deads2k

as per bot recommendation

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@dashpole
Copy link
Contributor Author

/test pull-kubernetes-node-e2e-containerd
/test pull-kubernetes-unit-windows-master
/test pull-kubernetes-unit

@dashpole dashpole force-pushed the graduate_kubelet_tracing branch from eb781f6 to 98f7c70 Compare June 18, 2025 19:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole, dims, SergeyKanzhelev, wojtek-t
Once this PR has been reviewed and has the lgtm label, please ask for approval from deads2k. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dashpole
Copy link
Contributor Author

/test pull-kubernetes-unit-windows-master

@liyuerich liyuerich mentioned this pull request Jun 20, 2025
Closed
@dashpole dashpole force-pushed the graduate_kubelet_tracing branch from 98f7c70 to 902c089 Compare June 23, 2025 16:41
@dashpole
Copy link
Contributor Author

Failure is unrelated: #132424

@richabanker
Copy link
Contributor

/triage accept

@k8s-ci-robot
Copy link
Contributor

@richabanker: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/triage accept

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richabanker
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 26, 2025
@dashpole dashpole force-pushed the graduate_kubelet_tracing branch from 902c089 to 5a20c38 Compare June 30, 2025 12:30
@dashpole
Copy link
Contributor Author

/test pull-kubernetes-unit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@liggitt liggitt Awaiting requested review from liggitt

@dims dims Awaiting requested review from dims

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@deads2k deads2k Awaiting requested review from deads2k

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@deads2k deads2k

@SergeyKanzhelev SergeyKanzhelev

@wojtek-t wojtek-t

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dashpole @k8s-ci-robot @wojtek-t @dims @SergeyKanzhelev @k8s-triage-robot @richabanker @deads2k