Skip to content

Add RealFIFOOptions struct to provide structured configuration for RealFIFO #132243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add RealFIFOOptions struct to provide structured configuration for RealFIFO #132243

wants to merge 1 commit into from
+56 −5

Conversation

xigang
Copy link
Member

@xigang xigang commented Jun 12, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds RealFIFOOptions struct and NewRealFIFOWithOptions() constructor to RealFIFO.

Makes it easier to add new configuration options in the future without breaking changes. for example, adding a logger or a FIFOMetricsProvider.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xigang
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 12, 2025
@xigang
Copy link
Member Author

xigang commented Jun 12, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 12, 2025
@xigang
Copy link
Member Author

xigang commented Jun 12, 2025 •
edited
Loading

cc @liggitt @deads2k @dims

@liggitt
Copy link
Member

liggitt commented Jun 12, 2025

I think I'd rather wait until we actually have a need for this before adding it

@xigang
Copy link
Member Author

xigang commented Jun 12, 2025 •
edited
Loading

@liggitt RealFIFO needs to expose metrics, so a MetricsProvider needs to be added to RealFIFOOptions.

I think we need to add options for RealFIFO.

The informer and reflector provider should probably be exposed in their respective options to allow consumers to override the metrics.

from: #129160 (review)

@liggitt
Copy link
Member

liggitt commented Jun 24, 2025

/assign @deads2k

@xigang
Copy link
Member Author

xigang commented Jun 25, 2025

@deads2k PTAL. Thanks！

@xigang
Copy link
Member Author

xigang commented Jun 26, 2025

ping @deads2k please help this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xigang @k8s-ci-robot @liggitt @deads2k