Promote OrderedNamespaceDeletion test to Conformance #132219
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM label has been added. Git tree hash: d7ab40ea83a3c83343d3c49fd84816305c807234
|
|
/triage accepted |
|
/hold This doesn't give enough time yet: Due to being |
|
it will get more soak time after #132483 |
Hmm? it actually should already have 2 weeks as of now and the test results are 100% green. |
|
Ah, I see we change it to no longer require serial. |
|
The tests is nicely passing without any flakes since removing serial |
This is a critical security fix that users should be able to depend on.
4eccf74 to
b367626
Compare
|
New changes are detected. LGTM label has been removed. |
/retest |
| Testname: Ordered Namespace Deletion | ||
| Description: Pods must be deleted before other objects when deleting a namespace. See https://kep.k8s.io/5080 | ||
| */ | ||
| f.It("namespace deletion should delete pod first", framework.WithFeatureGate(features.OrderedNamespaceDeletion), framework.WithConformance(), func(ctx context.Context) { |
There was a problem hiding this comment.
| f.It("namespace deletion should delete pod first", framework.WithFeatureGate(features.OrderedNamespaceDeletion), framework.WithConformance(), func(ctx context.Context) { | |
| f.It("namespace deletion should delete pod first", framework.WithConformance(), func(ctx context.Context) { |
if is conformance it should not carry feature gate, right?
What type of PR is this?
/kind feature
/sig architecture api-machinery
What this PR does / why we need it:
Promoted ordered namespace deletion test(s) to Conformance.
This feature is a critical security behavior change and users should be able to rely on this behavior.
See: https://kep.k8s.io/5080 and the associated CVE: #126587
Which issue(s) this PR is related to:
Fixes #131532
Special notes for your reviewer:
Tests are reliably green here: https://testgrid.k8s.io/sig-release-master-informing#gce-cos-master-serial&width=20&include-filter-by-regex=OrderedNamespaceDeletion&include-filter-by-regex=OrderedNamespaceDeletion
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: