Skip to content

Move ClusterEvent type to staging repo, leaving some functions (that contain logic internal to scheduler) in kubernetes/kubernetes #132190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

Move ClusterEvent type to staging repo, leaving some functions (that contain logic internal to scheduler) in kubernetes/kubernetes #132190

merged 4 commits into from
Jun 26, 2025

Conversation

ania-borowiec
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is part of a larger change that moves interfaces and type and func defiinitions to the staging repo "k8s.io/kube-scheduler", to allow users for importing scheduler framework interfaces without importing k/k repo.
This PR moves structs ClusterEvent, ActionType, EventResource, ClusterEventWithHint, types QueueingHint and QueueingHintFn from k/k to the staging repo. Functions handling matching events remain in k/k, since they contain logic internal to kube-scheduler and are not required by scheduling framework plugins.

Which issue(s) this PR is related to:

Part of #89930

Special notes for your reviewer:

Moving this in a separate PR, since the PR moving everything is just too big to be reviewed

Does this PR introduce a user-facing change?

Types: ClusterEvent, ActionType, EventResource, ClusterEventWithHint, QueueingHint and QueueingHintFn moved from pkg/scheduler/framework to k8s.io/kube-scheduler/framework.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 9, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Hi @ania-borowiec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 9, 2025
@ania-borowiec
Copy link
Contributor Author

/cc Maciej Skoczeń Kensei Nakada
Can you please add ok-to-test? Thanks!

@k8s-ci-robot k8s-ci-robot requested review from carlory and cofyc June 9, 2025 11:15
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2025
@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Jun 9, 2025
@ania-borowiec
Copy link
Contributor Author

/cc @macsko @sanposhiho
Can you please add ok-to-test? Thanks!

@k8s-ci-robot k8s-ci-robot requested review from macsko and sanposhiho June 9, 2025 11:43
@macsko
Copy link
Member

macsko commented Jun 9, 2025

/ok-to-test

macsko
macsko reviewed Jun 10, 2025
View reviewed changes
staging/src/k8s.io/kube-scheduler/framework/types.go Outdated

// Constants for GVKs.
//
// CAUTION for contributors: When you add a new EventResource, you must register a new one to allResources.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now allResource is in a different package, so you could add a path where to find it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here and updated other comments

@macsko
Copy link
Member

macsko commented Jun 10, 2025

/approve

Leaving second review to @sanposhiho

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@bart0sh bart0sh moved this from Triage to not-only-sig-node in SIG Node: code and documentation PRs Jun 10, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
@ania-borowiec
Copy link
Contributor Author

@sanposhiho FYI: this one's also rebased and ready for review, thanks!

@ania-borowiec ania-borowiec mentioned this pull request Jun 23, 2025
Open
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025
@ania-borowiec
Move ClusterEvent type to staging repo, leaving some functions (that …
5b16711 
…contain logic internal to scheduler) in kubernetes/kubernetes

apply review comment and fix linter warning
@ania-borowiec
update-vendor.sh
d4c3b87
@ania-borowiec
update doc comments
14d3dc5
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025
sanposhiho
sanposhiho approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7808191417fb08c79a095796203f070c523c7ead

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ania-borowiec, macsko, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanposhiho
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 00d3750 into kubernetes:master Jun 26, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from Archive-it to Done in SIG Node CI/Test Board Jun 26, 2025
@github-project-automation github-project-automation bot moved this from other-sig (sig-node-approved) to Done in SIG Node: code and documentation PRs Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 26, 2025
yujuhong pushed a commit to yujuhong/kubernetes that referenced this pull request Jun 26, 2025
@ania-borowiec @yujuhong
Move ClusterEvent type to staging repo, leaving some functions (that …
0bcf243 
…contain logic internal to scheduler) in kubernetes/kubernetes (kubernetes#132190)

* Move ClusterEvent type to staging repo, leaving some functions (that contain logic internal to scheduler) in kubernetes/kubernetes

apply review comment and fix linter warning

* update-vendor.sh

* update doc comments

* run update-vendor.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macsko macsko macsko left review comments

@sanposhiho sanposhiho sanposhiho approved these changes

@carlory carlory Awaiting requested review from carlory

@cofyc cofyc Awaiting requested review from cofyc

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@ania-borowiec @k8s-ci-robot @macsko @carlory @sanposhiho