Skip to content

Moving Scheduler interfaces to staging: Move Code and Status from pkg/scheduler/framework to k8s.io/kube-scheduler/framework #132087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Moving Scheduler interfaces to staging: Move Code and Status from pkg/scheduler/framework to k8s.io/kube-scheduler/framework #132087

merged 1 commit into from
Jul 1, 2025
+1,920 −1,888

Conversation

ania-borowiec
Copy link
Contributor

@ania-borowiec ania-borowiec commented Jun 4, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is part of a larger change that moves interfaces and type and func defiinitions to the staging repo "k8s.io/kube-scheduler", to allow users for importing scheduler framework interfaces without importing k/k repo.
This PR moves structs Code and Status from k/k to the staging repo

Which issue(s) this PR fixes:

Part of #89930

Special notes for your reviewer:

Moving this in a separate PR, since the PR moving everything is just too big to be reviewed

Does this PR introduce a user-facing change?

Types: Code and Status moved from pkg/scheduler/framework to staging repo.
Users should update import path for these types from "k8s.io/kubernetes/pkg/scheduler/framework" to "k8s.io/kube-scheduler/framework"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ania-borowiec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and cofyc June 4, 2025 08:11
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 4, 2025
@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Jun 4, 2025
@ania-borowiec
Copy link
Contributor Author

/cc @macsko @sanposhiho

@k8s-ci-robot k8s-ci-robot requested review from macsko and sanposhiho June 4, 2025 08:12
@macsko
Copy link
Member

macsko commented Jun 4, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
macsko
macsko reviewed Jun 4, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jun 30, 2025
@ania-borowiec ania-borowiec force-pushed the move_code_and_status branch from ab1761c to 7140f94 Compare June 30, 2025 09:29
@ania-borowiec
Copy link
Contributor Author

/lgtm /approve

/hold until the labels are cleaned up

Thanks @sanposhiho ! I cleaned up labels and squashed the commits.

@ania-borowiec
Copy link
Contributor Author

/cc @x13n do you think you could review this change on behalf of Cluster Autoscaler?
It's LGTMed by sig-scheduling.
Thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 30, 2025 •
edited
Loading

@ania-borowiec: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-cos-alpha-features 6f631aa link false /test pull-kubernetes-e2e-gce-cos-alpha-features
pull-kubernetes-e2e-gce-network-policies 6f631aa link false /test pull-kubernetes-e2e-gce-network-policies
pull-kubernetes-conformance-image-test 6f631aa link false /test pull-kubernetes-conformance-image-test
pull-kubernetes-e2e-kind-nftables 6f631aa link false /test pull-kubernetes-e2e-kind-nftables
pull-kubernetes-e2e-kind-alpha-beta-features 6f631aa link false /test pull-kubernetes-e2e-kind-alpha-beta-features
pull-kubernetes-e2e-gci-gce-ingress 6f631aa link false /test pull-kubernetes-e2e-gci-gce-ingress
pull-kubernetes-e2e-gce-storage-snapshot 6f631aa link false /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-gce-storage-slow 6f631aa link false /test pull-kubernetes-e2e-gce-storage-slow
pull-kubernetes-e2e-gce-csi-serial 6f631aa link false /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-cross 6f631aa link false /test pull-kubernetes-cross
pull-kubernetes-apidiff-client-go 6f631aa link false /test pull-kubernetes-apidiff-client-go
pull-kubernetes-e2e-capz-windows-master 6f631aa link false /test pull-kubernetes-e2e-capz-windows-master
pull-kubernetes-unit-windows-master 6f631aa link false /test pull-kubernetes-unit-windows-master
check-dependency-stats 6f631aa link false /test check-dependency-stats
pull-kubernetes-e2e-storage-kind-disruptive 6f631aa link false /test pull-kubernetes-e2e-storage-kind-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ania-borowiec ania-borowiec force-pushed the move_code_and_status branch from 7140f94 to ee8c265 Compare June 30, 2025 10:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho June 30, 2025 10:08
@x13n
Copy link
Member

x13n commented Jul 1, 2025

/approve

For autoscaler_contract

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ania-borowiec, macsko, sanposhiho, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@macsko
Copy link
Member

macsko commented Jul 1, 2025

/lgtm

As we have all approvals

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bf411404d57a37c948a116f5d782edd91f12f0bf

@sanposhiho
Copy link
Member

/remove-label api-review

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

@sanposhiho: Those labels are not set on the issue: api-review

In response to this:

/remove-label api-review

/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanposhiho
Copy link
Member

/remove-kind api-change

@k8s-ci-robot k8s-ci-robot removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2ee5682 into kubernetes:master Jul 1, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Archive-it to Done in SIG Node CI/Test Board Jul 1, 2025
@github-project-automation github-project-automation bot moved this from !SIG Auth to Closed / Done in SIG Auth Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macsko macsko macsko left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@cofyc cofyc Awaiting requested review from cofyc

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@sanposhiho sanposhiho

@macsko macsko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Apps
Status: Done
SIG Auth
Status: Closed / Done
SIG CLI
Status: Done
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
8 participants
@ania-borowiec @k8s-ci-robot @macsko @k8s-triage-robot @richabanker @cici37 @sanposhiho @x13n