remove general avaliable feature-gate DevicePluginCDIDevices #132083
+5
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlory
commented
Jun 4, 2025
test/e2e/feature/feature.go
Outdated
| // DevicePluginCDIDevices tests the CDI feature which is GA. | ||
| // This label is used for https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cdi-device-plugins | ||
| DevicePluginCDIDevices = framework.WithFeature(framework.ValidFeatures.Add("DevicePluginCDIDevices")) | ||
|
|
There was a problem hiding this comment.
Removing it is okay, see kubernetes/test-infra#34012
|
/cc @klueska |
|
/assign @derekwaynecarr |
150f25d to
db80fd9
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carlory, elezar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/triage accepted |
bart0sh
reviewed
Jul 1, 2025
| @@ -282,7 +280,7 @@ func testDevicePlugin(f *framework.Framework, pluginSockDir string) { | |||
| gomega.Expect(v1ResourcesForOurPod.Containers[0].Devices[0].DeviceIds).To(gomega.HaveLen(1)) | |||
| }) | |||
|
|
|||
| f.It("can make a CDI device accessible in a container", feature.DevicePluginCDIDevices, func(ctx context.Context) { | |||
| f.It("can make a CDI device accessible in a container", func(ctx context.Context) { | |||
There was a problem hiding this comment.
feature definition should be removed as well, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
remove general avaliable feature-gate DevicePluginCDIDevices
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: