Skip to content

[DRAFT-NOT-FOR-REVIEW] Draft changes to debug conformance test issues. #132073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DRAFT-NOT-FOR-REVIEW] Draft changes to debug conformance test issues. #132073

wants to merge 1 commit into from
+55 −11

Conversation

princepereira
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from robscott and sbangari June 3, 2025 12:12
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests area/kube-proxy area/test sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: princepereira
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric, robscott for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jun 3, 2025
@sbangari
Copy link
Contributor

sbangari commented Jun 3, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2025
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira
Copy link
Contributor Author

/test pull-kubernetes-verify

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira mentioned this pull request Jun 4, 2025
Open
@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from db2e73b to 74bf7cd Compare June 4, 2025 05:05
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@aojea
Copy link
Member

aojea commented Jun 4, 2025

@princepereira any doubts or findings or questions where we can help please let us know (cc @danwinship )

@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from 74bf7cd to 3a02ac3 Compare June 9, 2025 10:25
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

1 similar comment
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from 3a02ac3 to 1f8f9ae Compare June 20, 2025 09:12
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from 1f8f9ae to b3c5f7a Compare June 20, 2025 10:33
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from b3c5f7a to 63c27e6 Compare June 23, 2025 05:39
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from 63c27e6 to 1681ff7 Compare June 23, 2025 06:46
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@aojea
Copy link
Member

aojea commented Jun 25, 2025

any progress?

@princepereira
Copy link
Contributor Author

@aojea ,

The ClusterIP load balancer was created successfully, but the internal port used for the load balancer policy was incorrect. The expected targetPort was 8090, but the load balancer was configured with port 80, which is the external port. After making minor adjustments to the proxier code, the tests started passing.

image

However, I still need to investigate why the ports are being incorrectly assigned. If my assumption is correct, this allocation is happening in the proxy code (not the Windows proxy).

Apologies for the delay - I understand the importance of resolving this. I'm currently tied up with a high-priority customer issue that's taking up most of my time. Once that's resolved, I'll address this promptly.

@aojea
Copy link
Member

aojea commented Jun 25, 2025

Apologies for the delay - I understand the importance of resolving this. I'm currently tied up with a high-priority customer issue that's taking up most of my time. Once that's resolved, I'll address this promptly.

no rush, we understand we all have higher priorities, I was just checking in, thanks for looking into this.
cc: @danwinship for visibility

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from 1681ff7 to 306c0ab Compare June 28, 2025 17:04
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@princepereira princepereira force-pushed the ppereira-draft-kep4974 branch from 306c0ab to 33021dc Compare June 30, 2025 07:29
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 30, 2025 •
edited
Loading

@princepereira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-verify db2e73b link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott Awaiting requested review from robscott

@sbangari sbangari Awaiting requested review from sbangari

Assignees
No one assigned
Labels
area/conformance Issues or PRs related to kubernetes conformance tests area/kube-proxy area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@princepereira @k8s-ci-robot @sbangari @aojea