[WIP]: PodStartSLIDuration excludes init container runtime #131950
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @alimaazamat! |
|
Hi @alimaazamat. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alimaazamat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9e26af4 to
b606046
Compare
b606046 to
84042ad
Compare
| } | ||
| } | ||
|
|
||
| // Find when all main containers are running |
There was a problem hiding this comment.
I wonder whether as an approach it might be feasible/simpler/more precise to wait for all InitContainerStatuses to have non-nil Terminated, then subtract min(Terminated.StartedAt.Time) from max(Terminated.FinishedAt.Time) ?
| @@ -99,7 +102,8 @@ func (p *basicPodStartupLatencyTracker) ObservedPodOnWatch(pod *v1.Pod, when tim | |||
| if hasPodStartedSLO(pod) { | |||
| podStartingDuration := when.Sub(pod.CreationTimestamp.Time) | |||
| imagePullingDuration := state.lastFinishedPulling.Sub(state.firstStartedPulling) | |||
| podStartSLOduration := (podStartingDuration - imagePullingDuration).Seconds() | |||
| initContainerDuration := state.containersRunningTime.Sub(state.initContainerStartTime) | |||
| podStartSLOduration := (podStartingDuration - imagePullingDuration - initContainerDuration).Seconds() | |||
There was a problem hiding this comment.
Is it possible for init container execution to overlap image pulling?
e.g. the init container images are tiny, but the main container images are huge. The init containers pull quickly and start running while the main containers are still pulling?
I've no idea if this is possible, but I think this calculation relies on it being impossible, otherwise you'll double count?
|
/sig node |
|
Waiting for feedback from Sig Node before proceeding... |
|
@alimaazamat: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
PodStartSLIDuration should not include init container run time according to https://github.com/kubernetes/community/blob/master/sig-scalability/slos/pod_startup_latency.md
Which issue(s) this PR fixes:
Fixes #131733
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: