Skip to content

[doc] Update history of checkpoint support in Kubelet #131926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

esotsal
Copy link
Contributor

@esotsal esotsal commented May 23, 2025

Update table in kubelet/checkpointmanager/README.md adding missing
checkpoint packages with checkpoint support.

What type of PR is this?

/kind documentation

What this PR does / why we need it:

History of checkpointing support in Kubelet is not complete, this PR tries to fix this.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 23, 2025
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: esotsal
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esotsal
Copy link
Contributor Author

esotsal commented May 23, 2025

/retest

@esotsal esotsal force-pushed the update_history_of_checkpointing_support branch from 02eb5f0 to 2780e9c Compare June 1, 2025 09:26
@esotsal esotsal changed the title Update history of checkpoint support in Kubelet [doc] Update history of checkpoint support in Kubelet Jun 1, 2025
@esotsal esotsal force-pushed the update_history_of_checkpointing_support branch from 2780e9c to 74e42eb Compare June 1, 2025 09:28
@bart0sh
Copy link
Contributor

bart0sh commented Jun 10, 2025

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 10, 2025
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node: code and documentation PRs Jun 10, 2025
@esotsal esotsal force-pushed the update_history_of_checkpointing_support branch 2 times, most recently from 5b1ea9a to 0ca9d1c Compare June 11, 2025 06:35
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2025
@esotsal esotsal force-pushed the update_history_of_checkpointing_support branch from 0ca9d1c to 64f81d5 Compare June 11, 2025 06:36
provides the common APIs and the framework for implementing checkpointing.
Using same APIs across all the submodules will help maintaining consistency at
Kubelet level.
used by several other Kubelet submodules, `dockershim`, `devicemanager`, `pods`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have dockershim component in Kubelet? What's allocation manager?

Copy link
Contributor Author

@esotsal esotsal Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's allocation manager?

Allocation manager is part of package allocation, a recent addition for InPlacePodVerticalScaling, it handles tracking pod resource allocations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have dockershim component in Kubelet?

Dockershim has been removed from the Kubernetes project as of release 1.24, as a consequence dockershim checkpoint support has also been removed.

Updated commit with status column, please take another look.

@esotsal esotsal force-pushed the update_history_of_checkpointing_support branch from 64f81d5 to c9ffda3 Compare June 27, 2025 16:41
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2025
Update table in README.md:
- adding missing checkpoint packages
- addding status column to report removed checkpoint packages
- set status of dockershim checkpoint package to removed and status of
  all other checkpoint packages to In use.
@esotsal esotsal force-pushed the update_history_of_checkpointing_support branch from c9ffda3 to 56d977f Compare June 27, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants