cpumanager: uncorecache alignment for odd integer cpus #131850
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @wongchar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
|
/test pull-kubernetes-e2e-gce |
| sortFreeCPUs := freeCPUs.List() | ||
| // if all threads are available on each core, remove the last free cpu to satisfy cpu requirement | ||
| if len(sortFreeCPUs) > a.numCPUsNeeded { | ||
| sortFreeCPUs = sortFreeCPUs[:freeCPUs.Size()-1] |
There was a problem hiding this comment.
ok, we can enter here iff the accumulator is not satisfied after taking a full uncore group, so freeCPUs.Size() can't be < 1.
This seems to be covered by tests (line 1730 in the tests file) right?
There was a problem hiding this comment.
correct. Updated the comments, please let me know if still unclear
| if a.numCPUsNeeded%2 != 0 && a.topo.CPUsPerCore() > 1 { | ||
| // sort the freeCPUs available | ||
| sortFreeCPUs := freeCPUs.List() | ||
| // if all threads are available on each core, remove the last free cpu to satisfy cpu requirement |
There was a problem hiding this comment.
What could be more helpful is a short comment to describe why the last core can be dropped, replacing or augmenting the current comment
| // when SMT/hyperthread is enabled, remove the last cpu if cpu requirement is an odd integer value | ||
| // and if the number of free virtual cpus are greater than the needed cpus |
There was a problem hiding this comment.
comments should preferably describe the why (see also line 572 below)
| // when SMT/hyperthread is enabled, remove the last cpu if cpu requirement is an odd integer value | ||
| // and if the number of free virtual cpus are greater than the needed cpus | ||
| if a.numCPUsNeeded%2 != 0 && a.topo.CPUsPerCore() > 1 { | ||
| // sort the freeCPUs available |
There was a problem hiding this comment.
ditto, feel free to merge or remove these comments
|
/retest |
2c8fe23 to
f2502b3
Compare
50b7e45 to
bcd541c
Compare
bcd541c to
b15b507
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wongchar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wongchar: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Fix for
prefer-align-cpus-by-uncorecacheCPUManager option that allows odd-integer cpu allocation for containers on SMT/hyperthreading enabled processors.Which issue(s) this PR fixes:
Fixes #131610
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: