Skip to content

Remove deprecated LegacySidecarContainers feature gate #131463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated LegacySidecarContainers feature gate #131463

wants to merge 1 commit into from
+25 −583

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Apr 25, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

#130058

This removes the deprecated LegacySidecarContainers feature gate.
It was originally introduced to provide a workaround for potential side effects of the SidecarContainers feature.

It is now okay to remove it and duplicate code, as v1.33 demonstrates that there is no side effect.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The deprecated `LegacySidecarContainers` feature gate is completely removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and SataQiu April 25, 2025 06:56
@k8s-ci-robot k8s-ci-robot added area/test needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2025
@gjkim42 gjkim42 force-pushed the remove-legacysidecarcontainers-fg branch from 5667efa to 24424ea Compare April 25, 2025 06:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2025
@gjkim42 gjkim42 force-pushed the remove-legacysidecarcontainers-fg branch from 24424ea to 6a2ec63 Compare April 25, 2025 07:00
@gjkim42 gjkim42 marked this pull request as ready for review April 25, 2025 07:13
@gjkim42 gjkim42 force-pushed the remove-legacysidecarcontainers-fg branch from 6a2ec63 to 8a51e7a Compare April 25, 2025 07:20
@haircommander haircommander moved this from Triage to PRs Waiting on Author in SIG Node CI/Test Board Apr 30, 2025
@gjkim42 gjkim42 force-pushed the remove-legacysidecarcontainers-fg branch from 8a51e7a to 2dd9f5f Compare May 8, 2025 12:27
@gjkim42 gjkim42 changed the title WIP: Remove deprecated LegacySidecarContainers feature gate Remove deprecated LegacySidecarContainers feature gate May 8, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2025
@gjkim42
Copy link
Member Author

gjkim42 commented May 8, 2025

/assign @SergeyKanzhelev
Could you PTAL?

@gjkim42
Copy link
Member Author

gjkim42 commented May 8, 2025

/retest

@gjkim42 gjkim42 force-pushed the remove-legacysidecarcontainers-fg branch from 2dd9f5f to 3fe401a Compare June 26, 2025 14:24
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gjkim42
Once this PR has been reviewed and has the lgtm label, please ask for approval from sergeykanzhelev. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gjkim42
Copy link
Member Author

gjkim42 commented Jun 26, 2025

/cc @SergeyKanzhelev
Could you PTAL?
I'd like to remove this in v1.34.

Jefftree
Jefftree reviewed Jun 26, 2025
View reviewed changes
Copy link
Member

@Jefftree Jefftree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To respect compatibility version, can we follow the feature gate lifecycle for deprecated gates? https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/feature-gates.md#deprecation

Deprecated -> locked -> remove in 3 releases

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Jefftree left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@SataQiu SataQiu Awaiting requested review from SataQiu

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cici37 cici37 Awaiting requested review from cici37

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: PRs Waiting on Author
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gjkim42 @k8s-ci-robot @Jefftree @SergeyKanzhelev