The committers listed above are authorized under a signed CLA.

• ✅ login: MichaelMorrisEst / name: Michael Morris (78608df)

Welcome @MichaelMorrisEst!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Hi @MichaelMorrisEst. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MichaelMorrisEst
Once this PR has been reviewed and has the lgtm label, please assign smarterclayton for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Not sure if this is a conscious design decision, but the server-side tls cipher configurations are validated against the list available from the go runtime (staging/src/k8s.io/apiserver/pkg/server/options/serving.go), in the client-go case it's just pass-through. Can be a valid decision to delegate the validation logic to the client application, but I think it should be noted in godoc for the config parameter.

Do we need to add niche things like this into the client.Config?

I think someone who wants control over other detailed fields in http.Transport / tls.Config can construct their own http.Client with whatever settings they want, then call NewForConfigAndClient(), passing in their customized http.Client, to make their Kubernetes clientset.

I don't really want to end up reflecting every possible stdlib http.Client and http.Transport configuration knob in rest.Config

cc @BenTheElder for visibility to client configuration / transport construction / layering

I don't really want to end up reflecting every possible stdlib http.Client and http.Transport configuration knob in rest.Config

Totally!

cc @enj for client transport options flexibility / TLS cache impact

Re: the original issue ... #130428 (comment)

/remove-sig api-machinery

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale