Skip to content

update CCM image to v32.2.3 #130696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YifeiZhuang
Copy link

@YifeiZhuang YifeiZhuang commented Mar 10, 2025

What type of PR is this?

update the test image for CCM component, new image is available

gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v32.2.3

From new CCM release https://github.com/kubernetes/cloud-provider-gcp/releases/tag/ccm%2Fv32.2.3

/kind cleanup
/kind failing-test
/kind flake

What this PR does / why we need it:

update the test image for CCM component, new image is available

gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v32.2.3

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/RELEASE.md#update-gce-job-version



/assign aojea
/assign mmamczur

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @YifeiZhuang!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @YifeiZhuang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 10, 2025
@k8s-ci-robot k8s-ci-robot requested review from marseel and MrHohn March 10, 2025 18:41
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 10, 2025
@YifeiZhuang
Copy link
Author

/assign aojea
/assign mmamczur

@YifeiZhuang YifeiZhuang changed the title update CCM iamge to v32.2.3 update CCM image to v32.2.3 Mar 10, 2025
@YifeiZhuang
Copy link
Author

@aojea reminder please approve the PR. It looks mmamczur@ is not in the review/approval list here.
ref:

@aojea
Copy link
Member

aojea commented Mar 12, 2025

/ok-to-test
/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b9b9d478b97cbfc74a4af79f0bcf113fbc1e53ef

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, YifeiZhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
@YifeiZhuang
Copy link
Author

/test pull-kubernetes-e2e-gce


"no ready nodes", seem not new, not sure if it's flakiness or real issue.

Waiting for 4 ready nodes. 0 ready nodes, 4 registered. Retrying.
Detected 0 ready nodes, found 4 nodes out of expected 4. Your cluster may not be fully functional.

@pacoxu
Copy link
Member

pacoxu commented Mar 13, 2025

/hold
the CI keeps failing

Mar 13 00:50:08.077744 bootstrap-e2e-master kubelet[9480]: I0313 00:50:08.077711    9480 event.go:389] "Event occurred" object="kube-system/cloud-controller-manager-bootstrap-e2e-master" fieldPath="spec.containers{cloud-controller-manager}" kind="Pod" apiVersion="v1" type="Warning" reason="BackOff" message="Back-off restarting failed container cloud-controller-manager in pod cloud-controller-manager-bootstrap-e2e-master_kube-system(cfc4e3b5c5aff2b5a7fedd060d12b5f1)"

From kueblet log, we can see the cloud-controller-manager cannot start correctly after updating the image. https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/130696/pull-kubernetes-e2e-gce/1899975142994350080/artifacts/bootstrap-e2e-master/kubelet.log

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@aojea
Copy link
Member

aojea commented Mar 13, 2025

/hold

image seems to be wrong

@mmamczur
Copy link

the binary is not in the expected path

@aojea
Copy link
Member

aojea commented May 9, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

@YifeiZhuang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce 3a4b505 link true /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -23,7 +23,7 @@
"containers":[
{
"name": "cloud-controller-manager",
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v30.0.0",
"image": "gcr.io/k8s-staging-cloud-provider-gcp/cloud-controller-manager:v32.2.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a separate PR to address this: #132515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants