Skip to content

chore(apiextensions): Use ptr.To to replace the custom function #130677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(apiextensions): Use ptr.To to replace the custom function #130677

wants to merge 1 commit into from

Conversation

zhifei92
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This uses the generic functions in k8s.io/utils to replace the custom function.
See kubernetes/utils#283 for details.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from Jefftree March 10, 2025 06:32
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mikedanese March 10, 2025 06:32
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 10, 2025
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@aaron-prindle
Copy link
Contributor

/cc @Jefftree

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 11, 2025
@Jefftree
Copy link
Member

hm, unit test failure looks suspicious...

@zhifei92 zhifei92 force-pushed the deprecated-pointer-apiextensions branch from 15565a5 to 3bc927e Compare March 13, 2025 02:01
@zhifei92
Copy link
Contributor Author

@Jefftree PTAL, thx.

@zhifei92
Copy link
Contributor Author

/retest-required

@zhifei92
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@Jefftree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 483244b580ef606e8626661e37bb3847091b61d7

@zhifei92
Copy link
Contributor Author

zhifei92 commented Mar 14, 2025 •
edited
Loading

/cc @deads2k @jpbetz Please take a look, thx.

@zhifei92
Copy link
Contributor Author

/assign @deads2k @jpbetz Please take a look, thx.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2025
jpbetz
jpbetz approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@jpbetz jpbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpbetz, zhifei92
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhifei92 zhifei92 force-pushed the deprecated-pointer-apiextensions branch from ed3c6ca to 7c89a8f Compare June 27, 2025 02:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz June 27, 2025 02:15
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2025
@zhifei92
Copy link
Contributor Author

/approve /lgtm

@jpbetz I've rebased the code, please help to approve again.

@zhifei92
chore(apiextensions): Use ptr.To to replace the custom function
31e1fda 
Fix verify.

Fix failed unit test

Format code.
@zhifei92 zhifei92 force-pushed the deprecated-pointer-apiextensions branch from 7c89a8f to 31e1fda Compare June 27, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jefftree Jefftree Awaiting requested review from Jefftree

@mikedanese mikedanese Awaiting requested review from mikedanese

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@Jefftree Jefftree

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhifei92 @k8s-triage-robot @aaron-prindle @Jefftree @k8s-ci-robot @jpbetz