-
Notifications
You must be signed in to change notification settings - Fork 40.9k
chore(apiextensions): Use ptr.To to replace the custom function #130677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(apiextensions): Use ptr.To to replace the custom function #130677
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/cc @Jefftree /triage accepted |
hm, unit test failure looks suspicious... |
15565a5
to
3bc927e
Compare
@Jefftree PTAL, thx. |
/retest-required |
/test pull-kubernetes-e2e-gce |
/lgtm |
LGTM label has been added. Git tree hash: 483244b580ef606e8626661e37bb3847091b61d7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jpbetz, zhifei92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ed3c6ca
to
7c89a8f
Compare
New changes are detected. LGTM label has been removed. |
@jpbetz I've rebased the code, please help to approve again. |
Fix verify. Fix failed unit test Format code.
7c89a8f
to
31e1fda
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This uses the generic functions in
k8s.io/utils
to replace the custom function.See kubernetes/utils#283 for details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: