Point node-problem-detector windows image to the correct path. #130486
Conversation
|
Welcome @tonyzhc! |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @tonyzhc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tonyzhc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
| $DEFAULT_NPD_VERSION = '0.8.10-gke0.1' | ||
| $DEFAULT_NPD_RELEASE_PATH = 'https://storage.googleapis.com/gke-release/winnode' | ||
| $DEFAULT_NPD_VERSION = '0.8.20-0' | ||
| $DEFAULT_NPD_RELEASE_PATH = 'https://storage.googleapis.com/gke-release' |
There was a problem hiding this comment.
For reviewers it is in: https://console.cloud.google.com/storage/browser/gke-release/node-problem-detector
There was a problem hiding this comment.
Now I wonder if it should be: 0.8.20-0-g53e0152f-gke.0
| $DEFAULT_NPD_VERSION = '0.8.10-gke0.1' | ||
| $DEFAULT_NPD_RELEASE_PATH = 'https://storage.googleapis.com/gke-release/winnode' | ||
| $DEFAULT_NPD_VERSION = '0.8.20-0' | ||
| $DEFAULT_NPD_RELEASE_PATH = 'https://storage.googleapis.com/gke-release' | ||
| $DEFAULT_NPD_HASH = '97ddfe3544da9e02a1cfb55d24f329eb29d606fca7fbbf800415d5de9dbc29a00563f8e0d1919595c8e316fd989d45b09b13c07be528841fc5fd37e21d016a2d' |
There was a problem hiding this comment.
This hash probably needs to be updated as well.
There was a problem hiding this comment.
How can I find the hash?
There was a problem hiding this comment.
The console shows the MD5 hash: 00ed826f8907c5c67528e5715fd27c23 but it obviously does not look like what is set here hmm..
The previous change is here: #105688
There was a problem hiding this comment.
This seems like a SHA-256 Hash instead, I got it via:
gsutil cp gs://gke-release/winnode/node-problem-detector/node-problem-detector-v0.8.10-gke0.1-windows_amd64.tar.gz.sha512 local-file
openssl dgst -sha256 local-file
There might be some script to generate this hmm
There was a problem hiding this comment.
Oh wait this actually needs SHA512 instead of SHA256, if you read the steps below.
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
PDCSI driver windows tests are blocked because the test nodes do not come up healthy.
Which issue(s) this PR fixes:
Blocking kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#1953
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: